Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 backported "Log errors caught during sync steps" #26337

Merged

Conversation

metabase-bot[bot]
Copy link
Contributor

@metabase-bot metabase-bot bot commented Nov 10, 2022

* log errors caught during sync steps

* remove accidental extra parens
@metabase-bot metabase-bot bot enabled auto-merge (squash) November 10, 2022 02:28
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 64.26% // Head: 64.26% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (7c49113) compared to base (fd73801).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-x.45.x   #26337   +/-   ##
===============================================
  Coverage           64.26%   64.26%           
===============================================
  Files                3146     3146           
  Lines               92130    92131    +1     
  Branches            11689    11687    -2     
===============================================
+ Hits                59206    59212    +6     
+ Misses              28244    28241    -3     
+ Partials             4680     4678    -2     
Flag Coverage Δ
back-end 85.57% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/metabase/sync/util.clj 92.00% <100.00%> (+0.03%) ⬆️
src/metabase/models/query.clj 92.30% <0.00%> (ø)
src/metabase/driver/sql_jdbc/connection.clj 82.72% <0.00%> (+4.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@metabase-bot metabase-bot bot merged commit a1c4025 into release-x.45.x Nov 10, 2022
@metabase-bot metabase-bot bot deleted the backport-5eb764d64203217c43979d79c2e57d312df15469 branch November 10, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant