Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual backport] Pass date and time format to timeline forms #26381

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

ranquild
Copy link
Contributor

Backports #26289

@ranquild ranquild changed the title Pass date and time format to timeline forms [Manual backport] Pass date and time format to timeline forms Nov 10, 2022
@ranquild ranquild self-assigned this Nov 10, 2022
@ranquild ranquild requested a review from a team November 10, 2022 16:38
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 64.28% // Head: 64.26% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (18b99bd) compared to base (30b24ab).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release-x.45.x   #26381      +/-   ##
==================================================
- Coverage           64.28%   64.26%   -0.03%     
==================================================
  Files                3147     3148       +1     
  Lines               92143    92148       +5     
  Branches            11690    11691       +1     
==================================================
- Hits                59238    59215      -23     
- Misses              28220    28250      +30     
+ Partials             4685     4683       -2     
Flag Coverage Δ
front-end 45.12% <60.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
frontend/src/metabase-types/api/mocks/settings.ts 100.00% <ø> (ø)
...base/core/components/DateSelector/DateSelector.tsx 5.88% <ø> (ø)
...metabase/core/components/DateWidget/DateWidget.tsx 71.42% <ø> (ø)
...base/core/components/FormTextArea/FormTextArea.tsx 100.00% <ø> (ø)
...ommon/components/EditEventModal/EditEventModal.tsx 0.00% <ø> (-86.67%) ⬇️
...imelines/common/components/EventForm/EventForm.tsx 0.00% <0.00%> (-68.75%) ⬇️
.../common/components/NewEventModal/NewEventModal.tsx 0.00% <ø> (ø)
...es/common/components/TimelineForm/TimelineForm.tsx 80.00% <ø> (ø)
...imelines/common/containers/EventForm/EventForm.tsx 0.00% <0.00%> (ø)
...c/metabase/core/components/TimeInput/TimeInput.tsx 92.68% <100.00%> (+0.57%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ranquild ranquild merged commit eadd353 into release-x.45.x Nov 10, 2022
@ranquild ranquild deleted the backport-26178-fix-timeline-format branch November 10, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants