datetime-diff function for redshift #26758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calherries
changed the title
added 3 commits
November 30, 2022 11:57
calherries
added
the
backport
Codecov ReportBase: 64.35% // Head: 64.34% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #26758 +/- ##
==========================================
- Coverage 64.35% 64.34% -0.02%
==========================================
Files 3215 3217 +2
Lines 93099 93153 +54
Branches 11823 11851 +28
==========================================
+ Hits 59917 59939 +22
- Misses 28456 28479 +23
- Partials 4726 4735 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…TimeWithZoneOffset
This reverts commit 235f3ac.
qnkhuat
reviewed
Dec 7, 2022
qnkhuat
approved these changes
Dec 7, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Dec 8, 2022
* Add redshift implementation * Add failing tests * Fix bigquery * Formatting * fix? set-param for redshift * Replace literals for datetime-diff-time-zones-test * Actually use fields * Fix typo * Rename dataset * Add type/DateTimeWithTZ column, since redshift doesn't like type/DateTimeWithZoneOffset * Cast to timestamp for week diff * Revert "fix? set-param for redshift" This reverts commit 235f3ac. * Fix leap years * Remove redundant date-trunc * Formatting * Fix mismatched types * Fix extract * Add comment for why redshift needs an implementation Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
metabase-bot bot
added a commit
that referenced
this pull request
Dec 9, 2022
* Add redshift implementation * Add failing tests * Fix bigquery * Formatting * fix? set-param for redshift * Replace literals for datetime-diff-time-zones-test * Actually use fields * Fix typo * Rename dataset * Add type/DateTimeWithTZ column, since redshift doesn't like type/DateTimeWithZoneOffset * Cast to timestamp for week diff * Revert "fix? set-param for redshift" This reverts commit 235f3ac. * Fix leap years * Remove redundant date-trunc * Formatting * Fix mismatched types * Fix extract * Add comment for why redshift needs an implementation Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com> Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com> Co-authored-by: Ngoc Khuat <qn.khuat@gmail.com>
calherries
added a commit
that referenced
this pull request
Dec 14, 2022
calherries
added a commit
that referenced
this pull request
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the datetime-diff function for redshift.
Original datetime-diff PR: #25722
This change is