Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 backported "Fix Input and dropdown fields have different styles" #26877

Conversation

metabase-bot[bot]
Copy link
Contributor

@metabase-bot metabase-bot bot commented Dec 1, 2022

@metabase-bot metabase-bot bot enabled auto-merge (squash) December 1, 2022 18:22
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Notifying subscribers in CODENOTIFY files for diff d8d03b6...fbfead8.

Notify File(s)
@alxnddr frontend/src/metabase/visualizations/components/settings/ChartSettingInput.styled.tsx
frontend/src/metabase/visualizations/components/settings/ChartSettingInputNumeric.styled.tsx

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 64.32% // Head: 64.33% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (fbfead8) compared to base (d8d03b6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-x.45.x   #26877   +/-   ##
===============================================
  Coverage           64.32%   64.33%           
===============================================
  Files                3165     3166    +1     
  Lines               92750    92755    +5     
  Branches            11773    11773           
===============================================
+ Hits                59666    59671    +5     
  Misses              28364    28364           
  Partials             4720     4720           
Flag Coverage Δ
front-end 45.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...re/components/SelectButton/SelectButton.styled.tsx 61.53% <ø> (ø)
...nents/settings/ChartSettingInputNumeric.styled.tsx 100.00% <ø> (ø)
...src/metabase/components/InputBlurChange.styled.tsx 100.00% <100.00%> (ø)
frontend/src/metabase/core/style/input.ts 100.00% <100.00%> (ø)
...s/components/settings/ChartSettingInput.styled.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@metabase-bot metabase-bot bot merged commit 3fde8e5 into release-x.45.x Dec 1, 2022
@metabase-bot metabase-bot bot deleted the backport-fde11b5e69e63d68bb5654a9843b4b93caeede65 branch December 1, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant