Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repro #19373: Pivot table returns wrong (distinct) row totals #27457

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

nemanjaglumac
Copy link
Member

Status

PENDING REVIEW

What does this PR accomplish?

How to test this manually?

  • yarn test-cypress-open
  • frontend/test/metabase/scenarios/visualizations/reproductions/19373-pivot-wrong-distinct-value-totals.cy.spec.js
  • Unskip repro
  • The test should fail until the related issue is fixed

Additional notes:

  • Once the issue is fixed, please remove the .skip part (unskip the test completely)
  • Make sure the test is passing and
  • Merge it together with the fix

Screenshots:

image

@nemanjaglumac nemanjaglumac merged commit 3568171 into master Dec 29, 2022
@nemanjaglumac nemanjaglumac deleted the repro/issue_19373 branch December 29, 2022 11:08
nemanjaglumac added a commit that referenced this pull request Dec 29, 2022
* Repro #27427: Static-viz fails for unused returned column (#27441)

* Repro #19373: Pivot table returns wrong (distinct) row totals (#27457)

* Repro #18770: Post-aggregation filter disrupts drill-through (#27459)

* Repro #25250: Pivot Table doesn't show stand-alone values on collapsed sub-level grouping (#27460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants