Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metabase.util.schema to Malli #27471

Merged
merged 19 commits into from
Jan 5, 2023
Merged

metabase.util.schema to Malli #27471

merged 19 commits into from
Jan 5, 2023
+1,747 −996

Commits on Dec 30, 2022

  1. first step to migrate util/schema to malli

    @qnkhuat
    qnkhuat committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    e944abb View commit details
    Browse the repository at this point in the history

  2. more tests and better mesage handling

    @qnkhuat
    qnkhuat committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    687025e View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. remove with-error-message-malli and use put the error directly into the 

    schema
    @qnkhuat
    qnkhuat committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    df50f27 View commit details
    Browse the repository at this point in the history

  2. - NonBlankString -> NonBlankStringPlumatic 

    - NonBlankStringMalli -> NonBlankString
    @qnkhuat
    qnkhuat committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    fb8f29c View commit details
    Browse the repository at this point in the history

  3. remove defschema and just calls mc/schema when define on

    @qnkhuat
    qnkhuat committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    6e200f6 View commit details
    Browse the repository at this point in the history

  4. typo and fix kondo for defendpoint-async-schema

    @qnkhuat
    qnkhuat committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    7aa1728 View commit details
    Browse the repository at this point in the history

  5. add defendpoint-schema to clj-kondo's deprecated var

    @qnkhuat
    qnkhuat committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    818181f View commit details
    Browse the repository at this point in the history

  6. enterprise namespace too

    @qnkhuat
    qnkhuat committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    7dbed1e View commit details
    Browse the repository at this point in the history

  7. fix clj-kondo failing in test

    @qnkhuat
    qnkhuat committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    de5ba6e View commit details
    Browse the repository at this point in the history

  8. still fixing kondo in test ns

    @qnkhuat
    qnkhuat committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    e0ad6fe View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. merge with master

    @qnkhuat
    qnkhuat committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    8e3348b View commit details
    Browse the repository at this point in the history

  2. remove ignoring deprecated defschema-schema in clj-kondo, use clj-kon… 

    …do/ignore on all existsing usage instead
    @qnkhuat
    qnkhuat committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    6c43fa2 View commit details
    Browse the repository at this point in the history

  3. still miss a few places

    @qnkhuat
    qnkhuat committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    5b56531 View commit details
    Browse the repository at this point in the history

  4. move fn/error to fn instead of leaving it it the outer :and for some … 

    …schema
    @qnkhuat
    qnkhuat committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    98f7898 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into ngoc-malli-for-util-schema

    @qnkhuat
    qnkhuat committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    3830108 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. merge with master and fix conflicts

    @qnkhuat
    qnkhuat committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    144aea9 View commit details
    Browse the repository at this point in the history

  2. white space fix. *insert same same but different meme*

    @qnkhuat
    qnkhuat committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    8aa22b9 View commit details
    Browse the repository at this point in the history

  3. clj-kondo warning fixes

    @qnkhuat
    qnkhuat committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    8b44d4b View commit details
    Browse the repository at this point in the history

  4. fix misalign plumatic schema

    @qnkhuat
    qnkhuat committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    15d8627 View commit details
    Browse the repository at this point in the history