Add processing step to the date format string so that we get Day of Month #27557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onth Since the frontend sends a date-style string with various differences from how Java's Date Formatter expects things, we need to post-process some bits. The 'D' -> 'd' string replacement was missed in the post processing fn, and so in some cases it was missed altogether, causing this bug. Existing tests in `metabase.pulse.render.datetime-test` and `metabase.pulse.render.table-test` should already catch this issue. Prior to the change they would fail, but they now pass after adding this PR's changes.
adam-james-v
added
the
backport
…d-as-day-of-year-27469
Codecov ReportBase: 65.46% // Head: 65.21% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #27557 +/- ##
==========================================
- Coverage 65.46% 65.21% -0.26%
==========================================
Files 3192 3188 -4
Lines 92720 92696 -24
Branches 11777 11769 -8
==========================================
- Hits 60699 60451 -248
- Misses 27152 27391 +239
+ Partials 4869 4854 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
noahmoss
approved these changes
Jan 6, 2023
…d-as-day-of-year-27469
…d-as-day-of-year-27469
|
No failed tests 🎉 |
…d-as-day-of-year-27469
adam-james-v
deleted the
bugfix-static-viz-days-incorrectly-rendered-as-day-of-year-27469
branch
github-actions bot
pushed a commit
that referenced
this pull request
Jan 9, 2023
…onth (#27557) Since the frontend sends a date-style string with various differences from how Java's Date Formatter expects things, we need to post-process some bits. The 'D' -> 'd' string replacement was missed in the post processing fn, and so in some cases it was missed altogether, causing this bug. Existing tests in `metabase.pulse.render.datetime-test` and `metabase.pulse.render.table-test` should already catch this issue. Prior to the change they would fail, but they now pass after adding this PR's changes.
adam-james-v
added a commit
that referenced
this pull request
Jan 10, 2023
…onth (#27557) (#27600) Since the frontend sends a date-style string with various differences from how Java's Date Formatter expects things, we need to post-process some bits. The 'D' -> 'd' string replacement was missed in the post processing fn, and so in some cases it was missed altogether, causing this bug. Existing tests in `metabase.pulse.render.datetime-test` and `metabase.pulse.render.table-test` should already catch this issue. Prior to the change they would fail, but they now pass after adding this PR's changes. Co-authored-by: adam-james <21064735+adam-james-v@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #27469
Since the frontend sends a date-style string with various differences from how Java's Date Formatter expects things, we need to post-process some bits. The 'D' -> 'd' string replacement was missed in the post processing fn, and so in some cases it was missed altogether, causing this bug.
Existing tests in
metabase.pulse.render.datetime-testandmetabase.pulse.render.table-testshould already catch this issue. Prior to the change they would fail, but they now pass after adding this PR's changes.