Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed regex for latitude name type matching #27614

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Fixed regex for latitude name type matching #27614

merged 2 commits into from
Jan 13, 2023

Conversation

markbastian
Copy link
Contributor

@markbastian markbastian commented Jan 10, 2023 •
edited by camsaul
Loading

Fixes #24041

Fixed regex and put under test.

This change is Reviewable

@dpsutton dpsutton added the backport Automatically create PR on current release branch on merge label Jan 10, 2023
@dpsutton dpsutton mentioned this pull request Jan 10, 2023
Open
2 tasks
@codecov
Copy link

codecov bot commented Jan 10, 2023 •
edited
Loading

Codecov Report

Base: 65.47% // Head: 65.47% // No change to project coverage 👍

Coverage data is based on head (26423c6) compared to base (26423c6).
Patch has no changes to coverable lines.

❗ Current head 26423c6 differs from pull request most recent head b97fa90. Consider uploading reports for the commit b97fa90 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #27614   +/-   ##
=======================================
  Coverage   65.47%   65.47%           
=======================================
  Files        3183     3183           
  Lines       93002    93002           
  Branches    11807    11807           
=======================================
  Hits        60892    60892           
  Misses      27215    27215           
  Partials     4895     4895
Flag Coverage Δ
back-end 85.30% <0.00%> (ø)
front-end 47.05% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@deploysentinel
Copy link

deploysentinel bot commented Jan 10, 2023 •
edited
Loading

No failed tests 🎉

qnkhuat
qnkhuat approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@qnkhuat qnkhuat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is not part of the PR but it'd be nice if you add tests for longitude while you're at it.

tsmacdonald
tsmacdonald approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@tsmacdonald tsmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛵

@tsmacdonald
Copy link
Member

[just rebased it against master, mostly to restart CI since I think all the failures were flakes]

@paoliniluis paoliniluis merged commit f395e2f into master Jan 13, 2023
@paoliniluis paoliniluis deleted the lat-24041 branch January 13, 2023 14:35
@metabase-bot metabase-bot bot mentioned this pull request Jan 13, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Jan 13, 2023
@markbastian
Fixed regex for latitude name type matching (#27614)
dd09ef5 
* Fixed regex for latitude name type matching

* Grouping regexes by lon/lat
metabase-bot bot added a commit that referenced this pull request Jan 13, 2023
@metabase-bot @markbastian
Fixed regex for latitude name type matching (#27614) (#27676)
5c00021 
* Fixed regex for latitude name type matching

* Grouping regexes by lon/lat

Co-authored-by: Mark Bastian <markbastian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmacdonald tsmacdonald tsmacdonald approved these changes

@qnkhuat qnkhuat qnkhuat approved these changes

Assignees

@markbastian markbastian

Labels
backport Automatically create PR on current release branch on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Column name auto-classification not working for _latitude
7 participants
@markbastian @tsmacdonald @qnkhuat @paoliniluis @dpsutton @alxnddr @darksciencebase