Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporary remove renovate #27621

Merged
merged 1 commit into from
Jan 11, 2023
Merged

temporary remove renovate #27621

merged 1 commit into from
Jan 11, 2023

Conversation

alxnddr
Copy link
Member

@alxnddr alxnddr commented Jan 11, 2023

Changes

Removing Renovate from our repo since it has not been useful. The reason is that we have several quite old dependencies that block easy automatic upgrades. We need to manually bump deps to the state when nothing is ancient and then add the renovate bot again.

@ranquild could you please remove the bot integration from our repo?

@alxnddr alxnddr self-assigned this Jan 11, 2023
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 65.48% // Head: 65.47% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (b278adf) compared to base (b2de749).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27621      +/-   ##
==========================================
- Coverage   65.48%   65.47%   -0.01%     
==========================================
  Files        3182     3182              
  Lines       92640    92640              
  Branches    11774    11775       +1     
==========================================
- Hits        60661    60660       -1     
  Misses      27118    27118              
- Partials     4861     4862       +1     
Flag Coverage Δ
back-end 85.46% <ø> (-0.01%) ⬇️
front-end 47.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/metabase/driver/impl.clj 69.14% <0.00%> (-1.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@deploysentinel
Copy link

deploysentinel bot commented Jan 11, 2023

Current Test Results Summary

✅ 1428 Passing - ❌ 1 Failing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 01/11/2023 03:57:28am UTC)

Run Details

Running Workflow E2E Tests for PR on Github Actions

Commit: 6e9750e2d10f8bd3bcdb0ce3f32890bf06ba94a9

Started: 01/11/2023 03:29:26am UTC

❌ Failures

📄   frontend/test/metabase/scenarios/native-filters/sql-field-filter-string.cy.spec.js • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
scenarios > filters > sql filters > field filter > String when set as the default value for a required filter
Retry 2Retry 1Initial Attempt
Error: Timed out retrying after 4050ms: `cy.click()` failed because this element is det...
Timed out retrying after 4050ms: `cy.click()` failed because this element is detached from the DOM.

`<span class="text-bold">Synergi...</span>`

Cypress requires elements be attached in the DOM to interact with them.

The previous command that ran was:

  > `cy.findByText()`

This DOM element likely became detached somewhere between the previous and current command.

Common situations why this happens:
  - Your JS framework re-rendered asynchronously
  - Your app code reacted to an event firing and removed the element

You typically need to re-query for the element or add 'guards' which delay Cypress from running new commands.

https://on.cypress.io/element-has-detached-from-dom
11.11% (34) 34 / 306 runs
failed over last 7 days
3.27% (10) 10 / 306 runs
flaked over last 7 days

⚠️ Flakes

📄   frontend/test/metabase/scenarios/sharing/alert/alert-permissions.cy.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
scenarios > alert > alert permissions as a non-admin / normal user should let you unsubscribe from both your own and others' alerts
Retry 1Initial Attempt
0% (0) 0 / 283 runs
failed over last 7 days
0.35% (1) 1 / 283 run
flaked over last 7 days

📄   frontend/test/metabase/scenarios/dashboard/click-behavior.cy.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
scenarios > dashboard > dashboard cards > click behavior should show filters defined on a question with filter pass-thru (#15993)
Retry 2Retry 1Initial Attempt
2.61% (8) 8 / 306 runs
failed over last 7 days
10.78% (33) 33 / 306 runs
flaked over last 7 days

📄   frontend/test/metabase/scenarios/models/models-metadata.cy.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
scenarios > models metadata should edit native model metadata
Retry 1Initial Attempt
2.62% (8) 8 / 305 runs
failed over last 7 days
0.66% (2) 2 / 305 runs
flaked over last 7 days


Copy link
Member

@nemanjaglumac nemanjaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the Renovate bot.

@nemanjaglumac nemanjaglumac merged commit 9e0d7fd into master Jan 11, 2023
@nemanjaglumac nemanjaglumac deleted the remove-renovate branch January 11, 2023 15:43
@nemanjaglumac nemanjaglumac added backport Automatically create PR on current release branch on merge Type:Tech Debt or Refactoring labels Jan 11, 2023
github-actions bot pushed a commit that referenced this pull request Jan 11, 2023
metabase-bot bot added a commit that referenced this pull request Jan 11, 2023
Co-authored-by: Aleksandr Lesnenko <alxnddr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge Type:Tech Debt or Refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants