Allow wider dashboardHeader buttons #27844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npfitz
approved these changes
Jan 23, 2023
|
No failed tests 🎉 |
Codecov ReportBase: 66.12% // Head: 66.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #27844 +/- ##
=======================================
Coverage 66.12% 66.12%
=======================================
Files 3272 3272
Lines 94806 94806
Branches 12072 12069 -3
=======================================
+ Hits 62689 62692 +3
Misses 27150 27150
+ Partials 4967 4964 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were setting a fixed width on dashboard header buttons, which caused any icons that were wider than they were tall to get clipped. This allows rectangular icons to fit properly (note, both the text card and click icons are affected).
Other dashboard buttons still look fine