-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump node
to version 16
#27970
Bump node
to version 16
#27970
Conversation
@@ -1,4 +1,3 @@ | |||
import { XMLHttpRequest } from "xmlhttprequest"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was introduced in #27337, but doesn't seem to be needed to work in Node v16+ anymore
Codecov ReportBase: 66.26% // Head: 66.26% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #27970 +/- ##
=======================================
Coverage 66.26% 66.26%
=======================================
Files 3283 3283
Lines 95174 95174
Branches 12141 12141
=======================================
Hits 63069 63069
Misses 27083 27083
Partials 5022 5022
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
26cfeea
to
0991652
Compare
No failed tests 🎉 |
4cba97c
to
82e8b09
Compare
There are still problem presents when upgrading node version to 16 or 18.
So, there are still some stuff left to investigate about a proper and better fix. Now we'll just delete the unit failed unit tests as a short term solution. |
Oops, I accidentally clicked "delete branch" 🤦♂️ |
@kulyk I was going to do it anyway. No worries! |
e7064de
to
3438613
Compare
3438613
to
5ae802f
Compare
@@ -5,7 +5,7 @@ runs: | |||
- name: Prepare Node.js | |||
uses: actions/setup-node@v3 | |||
with: | |||
node-version: 14.x | |||
node-version: 16.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of people reported that they need to use exactly version 16.10.0
to not crash on their CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd maybe add a comment in the code here so we don't forget about this and change it by mistake.
If you decide to do that, please commit with [ci skip]
and I'll force-merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
nock
behave differently between v14 and v16+node
to version 16
As it might break the unit tests.
Why?
nock
librarySince the introduction of
nock
in #27337, we starts to see some inconsistency in the unit tests behavior run on Node v14 vs v16+. This leads to the conclusion that we should be using Node v16+ for both development + CI environment to make the tests more repeatable.Also, please note that we're using exactly Node
16.10.0
on our CI since a lot of people reported here jestjs/jest#11956. Any other 16 or 18 versions don't seem to work at all.Example failed runs
Other runs are hard to find since the PR is amended, but there was at least a single commit that I reran the tests a few times and it failed consistently when this couldn't be reproduced on machines using node V16+