MLv2 metadata calculation validation #29956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metamben
approved these changes
Apr 10, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @camsaul)
|
No failed tests 🎉 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #29956 +/- ##
==========================================
+ Coverage 69.41% 69.45% +0.04%
==========================================
Files 2844 2840 -4
Lines 98504 98476 -28
Branches 12528 12507 -21
==========================================
+ Hits 68373 68395 +22
+ Misses 24774 24731 -43
+ Partials 5357 5350 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 25 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #29952: validate that we can calculate metadata for all pMBQL queries. (This doesn't validate that it is correct, just that it doesn't fail).
So far this has caught the following bugs:
:breakoutfrom joins #29907type-ofcalculation doesn't work fordatetime-add,datetime-subtract, orconvert-timezonewith temporal string literals #29910type-ofnot working for aggregations containing:caseexpression #29935:metricclause #29936:field <name>clauses #29941:ends-withis broken #29947:percentilecolumn name calculation broken #29964Prereq for #29017 and #29825
This change is