Frontend cleanup #3444
Merged
Frontend cleanup #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@metabase/core-developers needs review |
|
Is this part of #927 👴 ? #927 has officially made it onto the page of oldest open issues |
tlrobinson
force-pushed
the
frontend-cleanup
branch
from
8e86827
to
e665262
Compare
…the-final-angular-frontier
|
Looks pretty good to me. One question I had was for the Flow types for some of the libraries like Underscore, Icepick etc are those our defs or community ones? If they're our custom ones we might want to consider trying to use the underscore ones at https://github.com/flowtype/flow-typed/ since I'm imagining those are a bit more vetted. |
|
Yeah some of them are based on the flowtype ones, it was just easiest to copy them over manually. Using their CLI tool is something to look into though. |
Remove Angular once and for all
tlrobinson
force-pushed
the
frontend-cleanup
branch
from
eca767e
to
f014b92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
query_builder/*.jsxcomponents intoquery_builder/componentslike the rest of the app.