Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Babel and MySQL2 Dependencies #35602

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Update Babel and MySQL2 Dependencies #35602

merged 3 commits into from
Nov 10, 2023

Conversation

iethree
Copy link
Contributor

@iethree iethree commented Nov 10, 2023 •
edited

Closes #33687

Description

  • Move mysql2 to dev dependencies and minor version update
  • Update all babel-related dependencies to the latest version

@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label Nov 10, 2023
@iethree iethree requested review from paoliniluis and a team November 10, 2023 15:35
@iethree iethree added the backport Automatically create PR on current release branch on merge label Nov 10, 2023
@paoliniluis
Copy link
Contributor

paoliniluis commented Nov 10, 2023 •
edited by uladzimirdev

@iethree don't we need that mysql2 package for actually doing the cypress e2e tests? I thought we had that and the postgres one just because of that

@iethree iethree mentioned this pull request Nov 10, 2023
Merged
@iethree iethree changed the title Update JS dependencies Update Babel and MySQL2 Dependencies Nov 10, 2023
@deploysentinel DeploySentinel
Copy link

deploysentinel bot commented Nov 10, 2023 •
edited

No failed tests 🎉

@iethree
Copy link
Contributor Author

iethree commented Nov 10, 2023

@ryancw don't we need that mysql2 package for actually doing the cypress e2e tests? I thought we had that and the postgres one just because of that

correct. we use it in e2e tests. that's why i moved to to devDependencies

@uladzimirdev
Copy link
Contributor

@iethree what about other babel deps?

@iethree
Copy link
Contributor Author

iethree commented Nov 10, 2023

@iethree what about other babel deps?

sure why not

@iethree iethree merged commit f685f1c into master Nov 10, 2023
103 checks passed
@iethree iethree deleted the deps-updates-111023 branch November 10, 2023 21:30
@github-actions GitHub Actions
Copy link

@iethree could not create a backport due to conflicts

@uladzimirdev uladzimirdev mentioned this pull request Nov 14, 2023
Merged
alxnddr pushed a commit that referenced this pull request Nov 15, 2023
@iethree @alxnddr
Update Babel and MySQL2 Dependencies (#35602)
3edab6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uladzimirdev uladzimirdev uladzimirdev approved these changes

@paoliniluis paoliniluis Awaiting requested review from paoliniluis

Assignees

@iethree iethree

Labels
backport Automatically create PR on current release branch on merge dependencies .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move mysql2 to devdependencies
3 participants
@iethree @paoliniluis @uladzimirdev