[MLv2] Implement automatic-insights drill
#36443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatic insights drills have some unusual conditions. This adds `metabase.lib.metadata/editable?` and checks it before returning any drills. On settings: In the app, `MetabaseSettings` is a global singleton and the settings are sometimes updated in place. In the JS testing environment several mock settings instances can exist at once, and the global singleton does not necessarily have the values we want for any given test. This PR makes `metabase.lib.metadata/setting` check for `describe` and `it` to see if we're in the testing environment, and to trust the metadata's `settings` in that case.
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
camsaul
reviewed
Dec 6, 2023
camsaul
approved these changes
Dec 6, 2023
This was referenced Dec 7, 2023
bshepherdson
added a commit
that referenced
this pull request
Dec 7, 2023
This was introduced by #36443.
bshepherdson
added a commit
that referenced
this pull request
Dec 8, 2023
This was introduced by #36443.
qnkhuat
pushed a commit
that referenced
this pull request
Dec 12, 2023
Automatic insights drills have some unusual conditions. This adds `metabase.lib.metadata/editable?` and checks it before returning any drills. On settings: In the app, `MetabaseSettings` is a global singleton and the settings are sometimes updated in place. In the JS testing environment several mock settings instances can exist at once, and the global singleton does not necessarily have the values we want for any given test. This PR makes `metabase.lib.metadata/setting` check for `describe` and `it` to see if we're in the testing environment, and to trust the metadata's `settings` in that case.
qnkhuat
pushed a commit
that referenced
this pull request
Dec 12, 2023
This was introduced by #36443.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[MLv2] Implement
automatic-insightsdrillAutomatic insights drills have some unusual conditions.
This adds
metabase.lib.metadata/editable?and checks it beforereturning any drills.
On settings:
In the app,
MetabaseSettingsis a global singleton and the settingsare sometimes updated in place. In the JS testing environment several
mock settings instances can exist at once, and the global singleton does
not necessarily have the values we want for any given test.
This PR makes
metabase.lib.metadata/settingcheck fordescribeanditglobals to see if this is the testing environment, and to trust themetadata's
settingsin that case.Implements the BE side of #33558.