[MLv2] Fix pivot drills integration with the FE #36509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were broken because `lib.js/pivot-types` was returning CLJS keywords rather than strings. Also makes applying drill-thrus less noisy (`log/info` -> `log/debug`). Unskips the FE integration tests for pivot drills. Fixes #33559.
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
|
No failed tests 🎉 |
camsaul
approved these changes
Dec 7, 2023
bshepherdson
deleted the
12-06-_MLv2_Fix_pivot_drills_integration_with_the_FE
branch
qnkhuat
pushed a commit
that referenced
this pull request
Dec 12, 2023
These were broken because `lib.js/pivot-types` was returning CLJS keywords rather than strings. Also makes applying drill-thrus less noisy (`log/info` -> `log/debug`). Unskips the FE integration tests for pivot drills. Fixes #33559.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were broken because
lib.js/pivot-typeswas returning CLJSkeywords rather than strings.
Also makes applying drill-thrus less noisy (
log/info->log/debug).Unskips the FE integration tests for pivot drills. Fixes #33559.