Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync remove log translation #36565

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Sync remove log translation #36565

merged 2 commits into from
Dec 8, 2023

Conversation

qnkhuat
Copy link
Contributor

@qnkhuat qnkhuat commented Dec 8, 2023

No description provided.

@metabase-bot metabase-bot bot added the .Team/BackendComponents also known as BEC label Dec 8, 2023
@qnkhuat qnkhuat added the no-backport Do not backport this PR to any branch label Dec 8, 2023
@qnkhuat qnkhuat requested a review from a team December 8, 2023 07:08
@qnkhuat qnkhuat enabled auto-merge (squash) December 8, 2023 09:35
@qnkhuat qnkhuat merged commit 355c35e into master Dec 8, 2023
104 checks passed
@qnkhuat qnkhuat deleted the sync-no-translation branch December 8, 2023 10:04
calherries
calherries reviewed Dec 8, 2023
View reviewed changes
Copy link
Contributor

@calherries calherries left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'm late to review, but can you fix this typo?

src/metabase/sync/sync_metadata/fields.clj Show resolved Hide resolved
@lbrdnk lbrdnk restored the sync-no-translation branch December 8, 2023 16:21
@lbrdnk lbrdnk deleted the sync-no-translation branch December 8, 2023 16:24
qnkhuat added a commit that referenced this pull request Dec 12, 2023
@qnkhuat
Sync remove log translation (#36565)
e233a7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calherries calherries calherries left review comments

@piranha piranha piranha approved these changes

Assignees

@qnkhuat qnkhuat

Labels
no-backport Do not backport this PR to any branch .Team/BackendComponents also known as BEC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qnkhuat @piranha @calherries