Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Replace question" action to dashboard cards #36744

Merged
merged 26 commits into from
Dec 14, 2023
Merged

Add "Replace question" action to dashboard cards #36744

merged 26 commits into from
Dec 14, 2023

Commits on Dec 13, 2023

  1. Remove isVirtualDashCard prop

    @kulyk
    kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    c4ccf2e View commit details
    Browse the repository at this point in the history

  2. Add "replace" button to DashCardActionsPanel

    @kulyk
    kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    9e0a584 View commit details
    Browse the repository at this point in the history

  3. Add QuestionPickerModal

    @kulyk
    kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    441d504 View commit details
    Browse the repository at this point in the history

  4. Add replaceCard action

    @kulyk
    kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    6b7f0ee View commit details
    Browse the repository at this point in the history

  5. Use /card/:id/query endpoint for swapped cards

    @kulyk
    kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    20194a1 View commit details
    Browse the repository at this point in the history

  6. Implement card replace

    @kulyk
    kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    7e21043 View commit details
    Browse the repository at this point in the history

  7. Add basic undo toast

    @kulyk
    kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    2f2ffd6 View commit details
    Browse the repository at this point in the history

  8. update-dashboard-card will update :card_id 

    Previously, `card_id` in `update-dashboard-card!` only applied if the dashcard was an action card. There was a cryptic comment about this, but it also indicates that maybe it's ok to update.

This unsticks FE work but still needs BE unit tests.
    @markbastian @kulyk
    markbastian authored and kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    7986019 View commit details
    Browse the repository at this point in the history

  9. Adding unit test for updating dashcard's card 

    The new test checks the state of a dashboard with a GET then PUTs the update setting the new card id and verifies the result.
    @markbastian @kulyk
    markbastian authored and kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    b746d46 View commit details
    Browse the repository at this point in the history

  10. Clean up DashCard test suite

    @kulyk
    kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    a8232aa View commit details
    Browse the repository at this point in the history

  11. Add tests for DashCard component

    @kulyk
    kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    86c0c1f View commit details
    Browse the repository at this point in the history

  12. Add tests for QuestionPickerModal component

    @kulyk
    kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    c9fe261 View commit details
    Browse the repository at this point in the history

  13. Add tests for replaceCard action

    @kulyk
    kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    8eb23ad View commit details
    Browse the repository at this point in the history

  14. Remove redundant action argument

    @kulyk
    kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    b0ba9b6 View commit details
    Browse the repository at this point in the history

  15. Add test for parameters auto-wiring

    @kulyk
    kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    a099d1b View commit details
    Browse the repository at this point in the history

  16. Fix unexpected card query endpoint usage

    @kulyk
    kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    e11c81d View commit details
    Browse the repository at this point in the history

  17. Use more accessible selector in saveDashboard

    @kulyk
    kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    f575c91 View commit details
    Browse the repository at this point in the history

  18. Add e2e tests

    @kulyk
    kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    efde45a View commit details
    Browse the repository at this point in the history

  19. Remove justAdded from createMockDashboardCard

    @kulyk
    kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    94ae13c View commit details
    Browse the repository at this point in the history

  20. Fix test setup

    @kulyk
    kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    970d809 View commit details
    Browse the repository at this point in the history

  21. Updating update-action-cards-test test 

    Under the old behavior, only action dashcards allowed changing their card ids. Now card ids can be changed for any dashcard type. This test captured the old behavior and has been updated to capture the new behavior.
    @markbastian
    markbastian committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    8b2a89f View commit details
    Browse the repository at this point in the history

  22. Remove previous events

    @kulyk
    kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    eff7b4c View commit details
    Browse the repository at this point in the history

  23. Track dashboard_card_replaced event

    @kulyk
    kulyk committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    bf2db12 View commit details
    Browse the repository at this point in the history

  24. Merge remote-tracking branch 'origin/36497-replace-dashcard-card' int… 

    …o 36497-replace-dashcard-card
    @markbastian
    markbastian committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    c8249d2 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Merge branch 'master' into 36497-replace-dashcard-card

    @kulyk
    kulyk committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    6e00cd2 View commit details
    Browse the repository at this point in the history

  2. Show "replace" action for erroring queries

    @kulyk
    kulyk committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    92bc305 View commit details
    Browse the repository at this point in the history