Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When updating an alert, don't also update the question #36866

Merged
merged 16 commits into from
Jan 3, 2024
Merged

When updating an alert, don't also update the question #36866

merged 16 commits into from
Jan 3, 2024

Commits on Jan 3, 2024

  1. Refactor some modals so they can be tested semantically 

    This sets the stage for #36866
    @rafpaf
    rafpaf committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    c78d325 View commit details
    Browse the repository at this point in the history

  2. Simplify deletion modal

    @rafpaf
    rafpaf committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    349a244 View commit details
    Browse the repository at this point in the history

  3. Ensure translation of deletion modal title

    @rafpaf
    rafpaf committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    eb2c061 View commit details
    Browse the repository at this point in the history

  4. When updating an alert, don't also update the question 

    The additional call to apiUpdateQuestion is not needed, since you can't
edit an alert without first saving the question

Fixes #36395
    @rafpaf
    rafpaf committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    ba3b966 View commit details
    Browse the repository at this point in the history

  5. wip

    @rafpaf
    rafpaf committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    65fd63d View commit details
    Browse the repository at this point in the history

  6. wip

    @rafpaf
    rafpaf committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    7345ad2 View commit details
    Browse the repository at this point in the history

  7. Improve test

    @rafpaf
    rafpaf committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    3642278 View commit details
    Browse the repository at this point in the history

  8. just changes in email alert

    @rafpaf
    rafpaf committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    89efba2 View commit details
    Browse the repository at this point in the history

  9. wip shrinking this diff, resetting some files to the master version

    @rafpaf
    rafpaf committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    6f227bb View commit details
    Browse the repository at this point in the history

  10. Reset Action.unit.spec.tsx

    @rafpaf
    rafpaf committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    71a8140 View commit details
    Browse the repository at this point in the history

  11. Reset CollectionUploadInfoModal.tsx

    @rafpaf
    rafpaf committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    582505d View commit details
    Browse the repository at this point in the history

  12. Reset common.unit.spec.tsx

    @rafpaf
    rafpaf committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    57b3808 View commit details
    Browse the repository at this point in the history

  13. No longer set role=dialog on div in WindowModal

    @rafpaf
    rafpaf committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    50b8a11 View commit details
    Browse the repository at this point in the history

  14. No longer set aria-label, aria-modal, and role=dialog on ModalContent… 

    … div
    @rafpaf
    rafpaf committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    e77885a View commit details
    Browse the repository at this point in the history

  15. Use data-testid not aria-label for testing the Edit your alert dialog

    @rafpaf
    rafpaf committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    038c043 View commit details
    Browse the repository at this point in the history

  16. another commit to nudge CI to run again

    @rafpaf
    rafpaf committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    4fcf70e View commit details
    Browse the repository at this point in the history