Bigquery sync partitioned fields #36892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 failed and 3 flaky tests on run #1041 ↗︎
Details:
Review all test suite changes for PR #36892 ↗︎ |
||||||||||||||||||||
calherries
reviewed
Dec 20, 2023
qnkhuat
force-pushed
the
ngoc-sync-partition-key
branch
from
1924b9d
to
837b5b6
Compare
calherries
approved these changes
Dec 20, 2023
calherries
approved these changes
Dec 20, 2023
calherries
approved these changes
Dec 22, 2023
|
@qnkhuat Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milestone 2 of #36668
This will sync whether a field is a partition field.
There is a special case for ingestion time partition because it'll be partitioned on a pseudo-column _PARTITIONTIME or _PARTITIONDATE. So to support the milestone 3, where we need to make our sync adds a filter for tables that require a filter, I've changed the code so that these 2 pseudo-columns are added manually.