[MLv2] Drop redundant :fields clauses from stages and joins #36959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
Passing run #1285 ↗︎
Details:
Review all test suite changes for PR #36959 ↗︎ |
||||||||||||||||||||
metamben
approved these changes
Dec 20, 2023
bshepherdson
force-pushed
the
mblib-drop-redundant-fields-clauses
branch
from
50c6850
to
7996e77
Compare
bshepherdson
force-pushed
the
mblib-drop-redundant-fields-clauses
branch
from
7996e77
to
5a9a0c4
Compare
ranquild
reviewed
Jan 2, 2024
| export function findColumnIndexForColumnSetting(columns, columnSetting) { | ||
| // NOTE: need to normalize field refs because they may be old style [fk->, 1, 2] | ||
| const fieldRef = normalizeFieldRef(columnSetting.fieldRef); | ||
| // first try to find by fieldRef | ||
| if (fieldRef != null) { | ||
| const index = _.findIndex(columns, col => | ||
| _.isEqual(fieldRef, normalizeFieldRef(fieldRefForColumn(col))), | ||
| areFieldRefsEqual(fieldRef, normalizeFieldRef(fieldRefForColumn(col))), |
There was a problem hiding this comment.
Dimension.parseMBQL(fieldRef).isSameBaseDimenson(normalizeFieldRef(fieldRefForColumn(col))) should do the same thing
ranquild
approved these changes
Jan 2, 2024
If they're equivalent to the default, they can be removed (for stages) or replaced by `:all` (on joins).
bshepherdson
force-pushed
the
mblib-drop-redundant-fields-clauses
branch
from
5a9a0c4
to
fb6b3b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If they're equivalent to the default, they can be removed (for stages)
or replaced by
:all(on joins).