Return group instead of just group_name for ApiKeys
#37061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
johnswanson
added
no-backport
Passing run #1276 ↗︎
Details:
Review all test suite changes for PR #37061 ↗︎ |
||||||||||||||||||||
johnswanson
force-pushed
the
delete-endpoint-for-api-keys
branch
from
90cb001
to
7b6fb13
Compare
johnswanson
force-pushed
the
12-21-Return_group_instead_of_just_group_name_with_ApiKeys
branch
from
90ca508
to
a453302
Compare
johnswanson
force-pushed
the
delete-endpoint-for-api-keys
branch
from
7b6fb13
to
a8f0183
Compare
johnswanson
force-pushed
the
12-21-Return_group_instead_of_just_group_name_with_ApiKeys
branch
from
a453302
to
f2b8067
Compare
johnswanson
force-pushed
the
delete-endpoint-for-api-keys
branch
from
a8f0183
to
cc9db8b
Compare
johnswanson
force-pushed
the
12-21-Return_group_instead_of_just_group_name_with_ApiKeys
branch
from
f2b8067
to
9d668df
Compare
This was referenced Dec 22, 2023
shaunlebron
force-pushed
the
delete-endpoint-for-api-keys
branch
from
cc9db8b
to
f230bda
Compare
shaunlebron
force-pushed
the
12-21-Return_group_instead_of_just_group_name_with_ApiKeys
branch
from
9d668df
to
0dda2d9
Compare
shaunlebron
force-pushed
the
delete-endpoint-for-api-keys
branch
from
f230bda
to
7d65dcd
Compare
shaunlebron
force-pushed
the
12-21-Return_group_instead_of_just_group_name_with_ApiKeys
branch
from
0dda2d9
to
f57533a
Compare
noahmoss
approved these changes
Dec 27, 2023
johnswanson
force-pushed
the
delete-endpoint-for-api-keys
branch
from
b9c735d
to
9a63671
Compare
johnswanson
force-pushed
the
12-21-Return_group_instead_of_just_group_name_with_ApiKeys
branch
from
f57533a
to
bef9a1b
Compare
johnswanson
force-pushed
the
delete-endpoint-for-api-keys
branch
3 times, most recently
from
1d1ee6c
to
6e93a7a
Compare
The frontend needs the group ID as well as the name, so let's return both in a similar shape as `updated_by`.
johnswanson
force-pushed
the
12-21-Return_group_instead_of_just_group_name_with_ApiKeys
branch
from
bef9a1b
to
0d29903
Compare
johnswanson
deleted the
12-21-Return_group_instead_of_just_group_name_with_ApiKeys
branch
|
@johnswanson Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just returning the
group_name, the frontend also needs the ID.