Add last_name to ApiKey users #37234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we generate a `:common_name` on Users, we check for the presence of both `first_name` and `last_name`. If either is `nil`, we don't generate a `common_name`. ApiKey users only have one name (the name of the ApiKey itself) but we should set the `last_name` to an empty string. This way, the common name will still be generated. Because the `metabase.models.user/insert-new-user!` function requires a NonBlankString for `first_name` and `last_name` if they're present, I went back to calling `t2/insert-returning-instances!` directly.
johnswanson
force-pushed
the
add-last-name-to-api-key-users
branch
from
8e25122
to
06d6253
Compare
noahmoss
approved these changes
Jan 4, 2024
|
@johnswanson Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we generate a
:common_nameon Users, we check for the presence of bothfirst_nameandlast_name. If either isnil, we don't generate acommon_name.ApiKey users only have one name (the name of the ApiKey itself) but we should set the
last_nameto an empty string. This way, the common name will still be generated.Because the
metabase.models.user/insert-new-user!function requires a NonBlankString forfirst_nameandlast_nameif they're present, I went back to callingt2/insert-returning-instances!directly.