Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate data notebook step to MLv2 #37302

Merged
merged 9 commits into from
Jan 9, 2024
Merged

Migrate data notebook step to MLv2 #37302

merged 9 commits into from
Jan 9, 2024

Conversation

ranquild
Copy link
Contributor

@ranquild ranquild commented Jan 5, 2024

Epic #36983
Closes #36738
Blocked by #37303

Also completely removes legacy query from Notebook.

How to verify:

  • Creating new queries based on tables and saved questions should work

Please note this is completely broken until the blocker above is fixed.

@ranquild ranquild requested a review from a team January 5, 2024 15:29
@ranquild ranquild added the no-backport Do not backport this PR to any branch label Jan 5, 2024
Copy link
Contributor

@kamilmielnik kamilmielnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR makes me feel at ease.

Copy link
Contributor

@uladzimirdev uladzimirdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@ranquild ranquild enabled auto-merge (squash) January 8, 2024 18:04
@ranquild ranquild merged commit a5b10b2 into master Jan 9, 2024
106 checks passed
@ranquild ranquild deleted the data-step-mlv2 branch January 9, 2024 14:17
Copy link

github-actions bot commented Jan 9, 2024

@ranquild Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryingComponents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MLv2] [FE] DataStep - remove usage of legacyQuery
3 participants