Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty stages when modifying the list of query columns in viz settings #37311

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

ranquild
Copy link
Contributor

@ranquild ranquild commented Jan 5, 2024

Closes #36746

When both adding or removing a field we could come up with an empty last stage that needs to be manually dropped. This is needed to be able to filter on query columns in dashboards.

@ranquild ranquild requested a review from a team January 5, 2024 16:11
@metabase-bot metabase-bot bot added .Team/QueryingComponents visual Run Percy visual testing labels Jan 5, 2024
Copy link

github-actions bot commented Jan 5, 2024

Codenotify: Notifying subscribers in CODENOTIFY files for diff 9b3e51e...96594be.

Notify File(s)
@alxnddr frontend/src/metabase/visualizations/components/settings/ChartSettingTableColumns/utils.ts

@ranquild ranquild added the no-backport Do not backport this PR to any branch label Jan 5, 2024
@ranquild ranquild merged commit 0a9e994 into master Jan 5, 2024
114 of 120 checks passed
@ranquild ranquild deleted the 36746-cleanup-query branch January 5, 2024 16:47
Copy link

github-actions bot commented Jan 5, 2024

@ranquild Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryingComponents visual Run Percy visual testing
Projects
None yet
2 participants