Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwrap value expressions when converting to legacy expression #37481

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

metamben
Copy link
Contributor

@metamben metamben commented Jan 9, 2024

Fixes #37461.

@metamben metamben requested review from uladzimirdev and a team January 9, 2024 21:54
@metamben metamben requested a review from camsaul as a code owner January 9, 2024 21:54
@metamben metamben added the no-backport Do not backport this PR to any branch label Jan 9, 2024
@metabase-bot metabase-bot bot added the .Team/QueryProcessor :hammer_and_wrench: label Jan 9, 2024
@metamben metamben added .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib and removed .Team/QueryProcessor :hammer_and_wrench: labels Jan 9, 2024
@uladzimirdev
Copy link
Contributor

@darksciencebase darksciencebase added the .Team/QueryProcessor :hammer_and_wrench: label Jan 10, 2024
@metamben metamben merged commit 6eb6017 into master Jan 11, 2024
122 of 125 checks passed
@metamben metamben deleted the 37461-constant-legacy-expression-handling branch January 11, 2024 15:00
Copy link

@metamben Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib no-backport Do not backport this PR to any branch .Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MLv2] [BE] [Bug] Support constants in expressions
4 participants