Update slack web api version #37484
Merged
Update slack web api version #37484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iethree
added
no-backport
alxnddr
approved these changes
Jan 9, 2024
|
@iethree Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates slack web api version which pulls in update versions of axios and follow-redirects (the package with the vulnerability)
There wasn't actually a vulnerability to us in this because we don't use Axios or the slack pacakage in the application, just in our release tooling, but this will make all the code scanning tools happy 馃榿.
Many thanks to Slack for being so quick responding to my PR: slackapi/node-slack-sdk#1716