New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic version of Models in Browse Data #37707
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafpaf
changed the title
DatabaseBrowser -> BrowseData, ported to tsx, took some notes
Models in Browse Data
Jan 15, 2024
rafpaf
commented
Jan 15, 2024
rafpaf
force-pushed
the
models-in-browse-data
branch
from
January 15, 2024 17:47
5f98d79
to
0395411
Compare
rafpaf
force-pushed
the
models-in-browse-data
branch
from
January 17, 2024 05:01
27d3f4f
to
763953d
Compare
Closed
rafpaf
force-pushed
the
models-in-browse-data
branch
from
January 18, 2024 02:01
5c31afc
to
f65cac1
Compare
Codenotify: Notifying subscribers in CODENOTIFY files for diff 4ac58f9...b5eb697. No notifications. |
rafpaf
commented
Jan 19, 2024
frontend/src/metabase/admin/permissions/components/FilterableTree/FilterableTree.tsx
Outdated
Show resolved
Hide resolved
rafpaf
commented
Jan 19, 2024
rafpaf
commented
Jan 19, 2024
rafpaf
commented
Jan 19, 2024
rafpaf
commented
Jan 19, 2024
rafpaf
commented
Jan 19, 2024
rafpaf
commented
Jan 19, 2024
rafpaf
commented
Jan 19, 2024
frontend/src/metabase/common/hooks/use-search-list-query/use-search-list-query.ts
Outdated
Show resolved
Hide resolved
rafpaf
commented
Jan 19, 2024
rafpaf
commented
Jan 19, 2024
rafpaf
commented
Jan 19, 2024
frontend/src/metabase/components/LastEditInfoLabel/LastEditInfoLabel.jsx
Outdated
Show resolved
Hide resolved
rafpaf
commented
Jan 19, 2024
rafpaf
commented
Jan 19, 2024
rafpaf
commented
Jan 19, 2024
rafpaf
commented
Jan 19, 2024
rafpaf
commented
Jan 19, 2024
frontend/src/metabase/components/LastEditInfoLabel/LastEditInfoLabel.tsx
Outdated
Show resolved
Hide resolved
@rafpaf Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
npfitz
pushed a commit
that referenced
this pull request
Feb 5, 2024
* Add Models and Databases tabs * Models are organized by collection * Exclude items in personal collections * Simplify BrowseHeader
npfitz
pushed a commit
that referenced
this pull request
Feb 6, 2024
* Add Models and Databases tabs * Models are organized by collection * Exclude items in personal collections * Simplify BrowseHeader
npfitz
pushed a commit
that referenced
this pull request
Feb 13, 2024
* Add Models and Databases tabs * Models are organized by collection * Exclude items in personal collections * Simplify BrowseHeader
npfitz
pushed a commit
that referenced
this pull request
Feb 17, 2024
* Add Models and Databases tabs * Models are organized by collection * Exclude items in personal collections * Simplify BrowseHeader
npfitz
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Add Models and Databases tabs * Models are organized by collection * Exclude items in personal collections * Simplify BrowseHeader
npfitz
pushed a commit
that referenced
this pull request
Feb 23, 2024
* Add Models and Databases tabs * Models are organized by collection * Exclude items in personal collections * Simplify BrowseHeader
iethree
pushed a commit
that referenced
this pull request
Feb 23, 2024
* Add Models and Databases tabs * Models are organized by collection * Exclude items in personal collections * Simplify BrowseHeader
iethree
added a commit
that referenced
this pull request
Feb 23, 2024
rough table selection. dont fire me plz make stuff prettier make mysql work in table picker make a tabbed entity picker reorganize stuff WIP collectionPicker collection picker works NextedItemPicker Styling more collectionpicker work make collectionpicker work Single Picker UI adding scroll left Tabbed UI add search fix key? Splitting up components yolo animation isolate search input reorg and fix some types nested item picker unit test types are much better scroll left when needed on mount handle snippets and some other stuff Modal unit tests Modal transition, default options adjustments, fixing endless searching allow all personal collections fix some types createNewCollection disable collection creation for read-only collections using entity loaders goodbye refs started working on types. Still some stuff to do I give up. Ryan help plz wip wip more wip fix stuff cool stuff cool stuff cool stuff more stuff fix backwards traversal use effective_location testing helpers # Conflicts: # frontend/src/metabase/common/components/EntityPicker/components/NestedItemPicker/NestedItemPicker.tsx dont use entity picker for move modal yet add a logical ui location takes a location like `/1/2/3/4/` and returns a "logical" ui location that includes only collections that the user can see. For instance, in the above location, if the user lacked permissions to collection 3, they could still see collection 4 but would see it as a child of 2, so it's effective ui location would be `/1/2/4/` remove location from other model types ie cards, snippets, etc would have a nil location. just remove test for ui logical location switch to existing `effective_location` had reinvented the wheel. There's already an effective_location which does exactly what we want. Add can-write? for UI concerns want it for collection picker UI info (remove or show greyed out). Tests are failing but want for them to start {:test 35, :pass 270, :fail 14, :error 0, :type :summary} better personal collection pathing no root permissions Basic version of Models in Browse Data (#37707) * Add Models and Databases tabs * Models are organized by collection * Exclude items in personal collections * Simplify BrowseHeader dashboard spec passing Initial collection selected infinite scroll right, fixing rebase issue native and models e2e getting better. remember to look at moderator icon styling adding search result filter, collection lookup for new collection modal use correct icons for special things top folder for snippets Endless API requests 😅 virtualize lists e2e tests are.... green?? now green e2e plz UI adjustments, empty collection state Lots of moving around. Types should be fairly happy, and started writing unit tests happy-ish unit tests? fix backend tests remove test/table pickers nicer loader use personal endpoint remove questionPicker use generic types where possible resolving import order stuff some type stuff sorted ✅✅ type checks ✅✅ more prettier fix lint error Nick is embarassed types back to green fix rebase conflicts
iethree
added a commit
that referenced
this pull request
Feb 23, 2024
rough table selection. dont fire me plz make stuff prettier make mysql work in table picker make a tabbed entity picker reorganize stuff WIP collectionPicker collection picker works NextedItemPicker Styling more collectionpicker work make collectionpicker work Single Picker UI adding scroll left Tabbed UI add search fix key? Splitting up components yolo animation isolate search input reorg and fix some types nested item picker unit test types are much better scroll left when needed on mount handle snippets and some other stuff Modal unit tests Modal transition, default options adjustments, fixing endless searching allow all personal collections fix some types createNewCollection disable collection creation for read-only collections using entity loaders goodbye refs started working on types. Still some stuff to do I give up. Ryan help plz wip wip more wip fix stuff cool stuff cool stuff cool stuff more stuff fix backwards traversal use effective_location testing helpers # Conflicts: # frontend/src/metabase/common/components/EntityPicker/components/NestedItemPicker/NestedItemPicker.tsx dont use entity picker for move modal yet add a logical ui location takes a location like `/1/2/3/4/` and returns a "logical" ui location that includes only collections that the user can see. For instance, in the above location, if the user lacked permissions to collection 3, they could still see collection 4 but would see it as a child of 2, so it's effective ui location would be `/1/2/4/` remove location from other model types ie cards, snippets, etc would have a nil location. just remove test for ui logical location switch to existing `effective_location` had reinvented the wheel. There's already an effective_location which does exactly what we want. Add can-write? for UI concerns want it for collection picker UI info (remove or show greyed out). Tests are failing but want for them to start {:test 35, :pass 270, :fail 14, :error 0, :type :summary} better personal collection pathing no root permissions Basic version of Models in Browse Data (#37707) * Add Models and Databases tabs * Models are organized by collection * Exclude items in personal collections * Simplify BrowseHeader dashboard spec passing Initial collection selected infinite scroll right, fixing rebase issue native and models e2e getting better. remember to look at moderator icon styling adding search result filter, collection lookup for new collection modal use correct icons for special things top folder for snippets Endless API requests 😅 virtualize lists e2e tests are.... green?? now green e2e plz UI adjustments, empty collection state Lots of moving around. Types should be fairly happy, and started writing unit tests happy-ish unit tests? fix backend tests remove test/table pickers nicer loader use personal endpoint remove questionPicker use generic types where possible resolving import order stuff some type stuff sorted ✅✅ type checks ✅✅ more prettier fix lint error Nick is embarassed types back to green fix rebase conflicts
iethree
added a commit
that referenced
this pull request
Feb 28, 2024
rough table selection. dont fire me plz make stuff prettier make mysql work in table picker make a tabbed entity picker reorganize stuff WIP collectionPicker collection picker works NextedItemPicker Styling more collectionpicker work make collectionpicker work Single Picker UI adding scroll left Tabbed UI add search fix key? Splitting up components yolo animation isolate search input reorg and fix some types nested item picker unit test types are much better scroll left when needed on mount handle snippets and some other stuff Modal unit tests Modal transition, default options adjustments, fixing endless searching allow all personal collections fix some types createNewCollection disable collection creation for read-only collections using entity loaders goodbye refs started working on types. Still some stuff to do I give up. Ryan help plz wip wip more wip fix stuff cool stuff cool stuff cool stuff more stuff fix backwards traversal use effective_location testing helpers # Conflicts: # frontend/src/metabase/common/components/EntityPicker/components/NestedItemPicker/NestedItemPicker.tsx dont use entity picker for move modal yet add a logical ui location takes a location like `/1/2/3/4/` and returns a "logical" ui location that includes only collections that the user can see. For instance, in the above location, if the user lacked permissions to collection 3, they could still see collection 4 but would see it as a child of 2, so it's effective ui location would be `/1/2/4/` remove location from other model types ie cards, snippets, etc would have a nil location. just remove test for ui logical location switch to existing `effective_location` had reinvented the wheel. There's already an effective_location which does exactly what we want. Add can-write? for UI concerns want it for collection picker UI info (remove or show greyed out). Tests are failing but want for them to start {:test 35, :pass 270, :fail 14, :error 0, :type :summary} better personal collection pathing no root permissions Basic version of Models in Browse Data (#37707) * Add Models and Databases tabs * Models are organized by collection * Exclude items in personal collections * Simplify BrowseHeader dashboard spec passing Initial collection selected infinite scroll right, fixing rebase issue native and models e2e getting better. remember to look at moderator icon styling adding search result filter, collection lookup for new collection modal use correct icons for special things top folder for snippets Endless API requests 😅 virtualize lists e2e tests are.... green?? now green e2e plz UI adjustments, empty collection state Lots of moving around. Types should be fairly happy, and started writing unit tests happy-ish unit tests? fix backend tests remove test/table pickers nicer loader use personal endpoint remove questionPicker use generic types where possible resolving import order stuff some type stuff sorted ✅✅ type checks ✅✅ more prettier fix lint error Nick is embarassed types back to green fix rebase conflicts
iethree
added a commit
that referenced
this pull request
Feb 29, 2024
rough table selection. dont fire me plz make stuff prettier make mysql work in table picker make a tabbed entity picker reorganize stuff WIP collectionPicker collection picker works NextedItemPicker Styling more collectionpicker work make collectionpicker work Single Picker UI adding scroll left Tabbed UI add search fix key? Splitting up components yolo animation isolate search input reorg and fix some types nested item picker unit test types are much better scroll left when needed on mount handle snippets and some other stuff Modal unit tests Modal transition, default options adjustments, fixing endless searching allow all personal collections fix some types createNewCollection disable collection creation for read-only collections using entity loaders goodbye refs started working on types. Still some stuff to do I give up. Ryan help plz wip wip more wip fix stuff cool stuff cool stuff cool stuff more stuff fix backwards traversal use effective_location testing helpers # Conflicts: # frontend/src/metabase/common/components/EntityPicker/components/NestedItemPicker/NestedItemPicker.tsx dont use entity picker for move modal yet add a logical ui location takes a location like `/1/2/3/4/` and returns a "logical" ui location that includes only collections that the user can see. For instance, in the above location, if the user lacked permissions to collection 3, they could still see collection 4 but would see it as a child of 2, so it's effective ui location would be `/1/2/4/` remove location from other model types ie cards, snippets, etc would have a nil location. just remove test for ui logical location switch to existing `effective_location` had reinvented the wheel. There's already an effective_location which does exactly what we want. Add can-write? for UI concerns want it for collection picker UI info (remove or show greyed out). Tests are failing but want for them to start {:test 35, :pass 270, :fail 14, :error 0, :type :summary} better personal collection pathing no root permissions Basic version of Models in Browse Data (#37707) * Add Models and Databases tabs * Models are organized by collection * Exclude items in personal collections * Simplify BrowseHeader dashboard spec passing Initial collection selected infinite scroll right, fixing rebase issue native and models e2e getting better. remember to look at moderator icon styling adding search result filter, collection lookup for new collection modal use correct icons for special things top folder for snippets Endless API requests 😅 virtualize lists e2e tests are.... green?? now green e2e plz UI adjustments, empty collection state Lots of moving around. Types should be fairly happy, and started writing unit tests happy-ish unit tests? fix backend tests remove test/table pickers nicer loader use personal endpoint remove questionPicker use generic types where possible resolving import order stuff some type stuff sorted ✅✅ type checks ✅✅ more prettier fix lint error Nick is embarassed types back to green fix rebase conflicts
iethree
added a commit
that referenced
this pull request
Feb 29, 2024
rough table selection. dont fire me plz make stuff prettier make mysql work in table picker make a tabbed entity picker reorganize stuff WIP collectionPicker collection picker works NextedItemPicker Styling more collectionpicker work make collectionpicker work Single Picker UI adding scroll left Tabbed UI add search fix key? Splitting up components yolo animation isolate search input reorg and fix some types nested item picker unit test types are much better scroll left when needed on mount handle snippets and some other stuff Modal unit tests Modal transition, default options adjustments, fixing endless searching allow all personal collections fix some types createNewCollection disable collection creation for read-only collections using entity loaders goodbye refs started working on types. Still some stuff to do I give up. Ryan help plz wip wip more wip fix stuff cool stuff cool stuff cool stuff more stuff fix backwards traversal use effective_location testing helpers # Conflicts: # frontend/src/metabase/common/components/EntityPicker/components/NestedItemPicker/NestedItemPicker.tsx dont use entity picker for move modal yet add a logical ui location takes a location like `/1/2/3/4/` and returns a "logical" ui location that includes only collections that the user can see. For instance, in the above location, if the user lacked permissions to collection 3, they could still see collection 4 but would see it as a child of 2, so it's effective ui location would be `/1/2/4/` remove location from other model types ie cards, snippets, etc would have a nil location. just remove test for ui logical location switch to existing `effective_location` had reinvented the wheel. There's already an effective_location which does exactly what we want. Add can-write? for UI concerns want it for collection picker UI info (remove or show greyed out). Tests are failing but want for them to start {:test 35, :pass 270, :fail 14, :error 0, :type :summary} better personal collection pathing no root permissions Basic version of Models in Browse Data (#37707) * Add Models and Databases tabs * Models are organized by collection * Exclude items in personal collections * Simplify BrowseHeader dashboard spec passing Initial collection selected infinite scroll right, fixing rebase issue native and models e2e getting better. remember to look at moderator icon styling adding search result filter, collection lookup for new collection modal use correct icons for special things top folder for snippets Endless API requests 😅 virtualize lists e2e tests are.... green?? now green e2e plz UI adjustments, empty collection state Lots of moving around. Types should be fairly happy, and started writing unit tests happy-ish unit tests? fix backend tests remove test/table pickers nicer loader use personal endpoint remove questionPicker use generic types where possible resolving import order stuff some type stuff sorted ✅✅ type checks ✅✅ more prettier fix lint error Nick is embarassed types back to green fix rebase conflicts
iethree
added a commit
that referenced
this pull request
Feb 29, 2024
rough table selection. dont fire me plz make stuff prettier make mysql work in table picker make a tabbed entity picker reorganize stuff WIP collectionPicker collection picker works NextedItemPicker Styling more collectionpicker work make collectionpicker work Single Picker UI adding scroll left Tabbed UI add search fix key? Splitting up components yolo animation isolate search input reorg and fix some types nested item picker unit test types are much better scroll left when needed on mount handle snippets and some other stuff Modal unit tests Modal transition, default options adjustments, fixing endless searching allow all personal collections fix some types createNewCollection disable collection creation for read-only collections using entity loaders goodbye refs started working on types. Still some stuff to do I give up. Ryan help plz wip wip more wip fix stuff cool stuff cool stuff cool stuff more stuff fix backwards traversal use effective_location testing helpers # Conflicts: # frontend/src/metabase/common/components/EntityPicker/components/NestedItemPicker/NestedItemPicker.tsx dont use entity picker for move modal yet add a logical ui location takes a location like `/1/2/3/4/` and returns a "logical" ui location that includes only collections that the user can see. For instance, in the above location, if the user lacked permissions to collection 3, they could still see collection 4 but would see it as a child of 2, so it's effective ui location would be `/1/2/4/` remove location from other model types ie cards, snippets, etc would have a nil location. just remove test for ui logical location switch to existing `effective_location` had reinvented the wheel. There's already an effective_location which does exactly what we want. Add can-write? for UI concerns want it for collection picker UI info (remove or show greyed out). Tests are failing but want for them to start {:test 35, :pass 270, :fail 14, :error 0, :type :summary} better personal collection pathing no root permissions Basic version of Models in Browse Data (#37707) * Add Models and Databases tabs * Models are organized by collection * Exclude items in personal collections * Simplify BrowseHeader dashboard spec passing Initial collection selected infinite scroll right, fixing rebase issue native and models e2e getting better. remember to look at moderator icon styling adding search result filter, collection lookup for new collection modal use correct icons for special things top folder for snippets Endless API requests 😅 virtualize lists e2e tests are.... green?? now green e2e plz UI adjustments, empty collection state Lots of moving around. Types should be fairly happy, and started writing unit tests happy-ish unit tests? fix backend tests remove test/table pickers nicer loader use personal endpoint remove questionPicker use generic types where possible resolving import order stuff some type stuff sorted ✅✅ type checks ✅✅ more prettier fix lint error Nick is embarassed types back to green fix rebase conflicts
iethree
added a commit
that referenced
this pull request
Mar 1, 2024
rough table selection. dont fire me plz make stuff prettier make mysql work in table picker make a tabbed entity picker reorganize stuff WIP collectionPicker collection picker works NextedItemPicker Styling more collectionpicker work make collectionpicker work Single Picker UI adding scroll left Tabbed UI add search fix key? Splitting up components yolo animation isolate search input reorg and fix some types nested item picker unit test types are much better scroll left when needed on mount handle snippets and some other stuff Modal unit tests Modal transition, default options adjustments, fixing endless searching allow all personal collections fix some types createNewCollection disable collection creation for read-only collections using entity loaders goodbye refs started working on types. Still some stuff to do I give up. Ryan help plz wip wip more wip fix stuff cool stuff cool stuff cool stuff more stuff fix backwards traversal use effective_location testing helpers # Conflicts: # frontend/src/metabase/common/components/EntityPicker/components/NestedItemPicker/NestedItemPicker.tsx dont use entity picker for move modal yet add a logical ui location takes a location like `/1/2/3/4/` and returns a "logical" ui location that includes only collections that the user can see. For instance, in the above location, if the user lacked permissions to collection 3, they could still see collection 4 but would see it as a child of 2, so it's effective ui location would be `/1/2/4/` remove location from other model types ie cards, snippets, etc would have a nil location. just remove test for ui logical location switch to existing `effective_location` had reinvented the wheel. There's already an effective_location which does exactly what we want. Add can-write? for UI concerns want it for collection picker UI info (remove or show greyed out). Tests are failing but want for them to start {:test 35, :pass 270, :fail 14, :error 0, :type :summary} better personal collection pathing no root permissions Basic version of Models in Browse Data (#37707) * Add Models and Databases tabs * Models are organized by collection * Exclude items in personal collections * Simplify BrowseHeader dashboard spec passing Initial collection selected infinite scroll right, fixing rebase issue native and models e2e getting better. remember to look at moderator icon styling adding search result filter, collection lookup for new collection modal use correct icons for special things top folder for snippets Endless API requests 😅 virtualize lists e2e tests are.... green?? now green e2e plz UI adjustments, empty collection state Lots of moving around. Types should be fairly happy, and started writing unit tests happy-ish unit tests? fix backend tests remove test/table pickers nicer loader use personal endpoint remove questionPicker use generic types where possible resolving import order stuff some type stuff sorted ✅✅ type checks ✅✅ more prettier fix lint error Nick is embarassed types back to green fix rebase conflicts
iethree
added a commit
that referenced
this pull request
Mar 1, 2024
rough table selection. dont fire me plz make stuff prettier make mysql work in table picker make a tabbed entity picker reorganize stuff WIP collectionPicker collection picker works NextedItemPicker Styling more collectionpicker work make collectionpicker work Single Picker UI adding scroll left Tabbed UI add search fix key? Splitting up components yolo animation isolate search input reorg and fix some types nested item picker unit test types are much better scroll left when needed on mount handle snippets and some other stuff Modal unit tests Modal transition, default options adjustments, fixing endless searching allow all personal collections fix some types createNewCollection disable collection creation for read-only collections using entity loaders goodbye refs started working on types. Still some stuff to do I give up. Ryan help plz wip wip more wip fix stuff cool stuff cool stuff cool stuff more stuff fix backwards traversal use effective_location testing helpers # Conflicts: # frontend/src/metabase/common/components/EntityPicker/components/NestedItemPicker/NestedItemPicker.tsx dont use entity picker for move modal yet add a logical ui location takes a location like `/1/2/3/4/` and returns a "logical" ui location that includes only collections that the user can see. For instance, in the above location, if the user lacked permissions to collection 3, they could still see collection 4 but would see it as a child of 2, so it's effective ui location would be `/1/2/4/` remove location from other model types ie cards, snippets, etc would have a nil location. just remove test for ui logical location switch to existing `effective_location` had reinvented the wheel. There's already an effective_location which does exactly what we want. Add can-write? for UI concerns want it for collection picker UI info (remove or show greyed out). Tests are failing but want for them to start {:test 35, :pass 270, :fail 14, :error 0, :type :summary} better personal collection pathing no root permissions Basic version of Models in Browse Data (#37707) * Add Models and Databases tabs * Models are organized by collection * Exclude items in personal collections * Simplify BrowseHeader dashboard spec passing Initial collection selected infinite scroll right, fixing rebase issue native and models e2e getting better. remember to look at moderator icon styling adding search result filter, collection lookup for new collection modal use correct icons for special things top folder for snippets Endless API requests 😅 virtualize lists e2e tests are.... green?? now green e2e plz UI adjustments, empty collection state Lots of moving around. Types should be fairly happy, and started writing unit tests happy-ish unit tests? fix backend tests remove test/table pickers nicer loader use personal endpoint remove questionPicker use generic types where possible resolving import order stuff some type stuff sorted ✅✅ type checks ✅✅ more prettier fix lint error Nick is embarassed types back to green fix rebase conflicts
iethree
added a commit
that referenced
this pull request
Mar 1, 2024
* Entity Picker Squash rough table selection. dont fire me plz make stuff prettier make mysql work in table picker make a tabbed entity picker reorganize stuff WIP collectionPicker collection picker works NextedItemPicker Styling more collectionpicker work make collectionpicker work Single Picker UI adding scroll left Tabbed UI add search fix key? Splitting up components yolo animation isolate search input reorg and fix some types nested item picker unit test types are much better scroll left when needed on mount handle snippets and some other stuff Modal unit tests Modal transition, default options adjustments, fixing endless searching allow all personal collections fix some types createNewCollection disable collection creation for read-only collections using entity loaders goodbye refs started working on types. Still some stuff to do I give up. Ryan help plz wip wip more wip fix stuff cool stuff cool stuff cool stuff more stuff fix backwards traversal use effective_location testing helpers # Conflicts: # frontend/src/metabase/common/components/EntityPicker/components/NestedItemPicker/NestedItemPicker.tsx dont use entity picker for move modal yet add a logical ui location takes a location like `/1/2/3/4/` and returns a "logical" ui location that includes only collections that the user can see. For instance, in the above location, if the user lacked permissions to collection 3, they could still see collection 4 but would see it as a child of 2, so it's effective ui location would be `/1/2/4/` remove location from other model types ie cards, snippets, etc would have a nil location. just remove test for ui logical location switch to existing `effective_location` had reinvented the wheel. There's already an effective_location which does exactly what we want. Add can-write? for UI concerns want it for collection picker UI info (remove or show greyed out). Tests are failing but want for them to start {:test 35, :pass 270, :fail 14, :error 0, :type :summary} better personal collection pathing no root permissions Basic version of Models in Browse Data (#37707) * Add Models and Databases tabs * Models are organized by collection * Exclude items in personal collections * Simplify BrowseHeader dashboard spec passing Initial collection selected infinite scroll right, fixing rebase issue native and models e2e getting better. remember to look at moderator icon styling adding search result filter, collection lookup for new collection modal use correct icons for special things top folder for snippets Endless API requests 😅 virtualize lists e2e tests are.... green?? now green e2e plz UI adjustments, empty collection state Lots of moving around. Types should be fairly happy, and started writing unit tests happy-ish unit tests? fix backend tests remove test/table pickers nicer loader use personal endpoint remove questionPicker use generic types where possible resolving import order stuff some type stuff sorted ✅✅ type checks ✅✅ more prettier fix lint error Nick is embarassed types back to green fix rebase conflicts * new collection modal polish, bad nav link stuff * removing TFolder * gathering collection picker components * auto selecting newly created collections * handle confirm on Enter * formCollectionPicker cleanup * border on selected search result * NavLink variants * virtualize search results * fixing icon color on variants * empty collection and search results state * default options spread, removing commented tests, actionButtons * moving New Collection Dialog, localizing header * make entityPickerModal generic * cleanup * update unit tests * update e2e tests * fix type exports * fix 1 more unit test * last test fixes plz * better loading behaviors * improved x-scrolling * remove imperative handle on scroll, scroll to selected item on mount * fix virtualizer type * scroll after measuring * clean up your hooks man * smooth out loading behavior * happy little typescript types * update collection id type * cancel pending search requests * handle whitespace search * cleanup * more cleanup * lets null coalesce instead * fix type * small type fix * Make a more versatile and easy-to-use list virtualizer * better mock * fix rebase conflicts * even more cleanup * ok raffi was right about the scrolling * test fixes * submit button niceties * wider new collection button * make jsdom happy * lighter navlink variant --------- Co-authored-by: Ryan Laurie <iethree@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #36368
Description
This PR adds models to the Browse Data tab. It provides these sub-features:
These sub-features will be addressed in follow-up PRs:
How to verify
Click 'Browse Data' in the sidebar on the left. Click the two tabs.
Checklist