Rework findColumnSettingIndexForColumn to MLv2 #37856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uladzimirdev
changed the title
|
uladzimirdev
force-pushed
the
mlv2-find-column-settings-2
branch
from
57de6c0
to
765de41
Compare
uladzimirdev
changed the title
Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
|
@uladzimirdev Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #37677
Description
Rework to MLv2
How to verify
Test should pass
Demo
This is why I updated the test
https://www.loom.com/share/7b0c28c3afdb4643b0ea56e570babc8c
Checklist