Add BE for routing billing status #38153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
qwef
commented
Feb 5, 2024
| @@ -28,6 +29,9 @@ | |||
| ;; and follow the convention. | |||
| (compojure/context | |||
| "/ee" [] | |||
| (compojure/context | |||
| "/billing" [] | |||
| billing/routes) | |||
There was a problem hiding this comment.
Should I add a premium feature here? Unsure because it seems like anyone with a token should access this, but no other route is like this.
noahmoss
approved these changes
Feb 6, 2024
| @@ -28,6 +29,9 @@ | |||
| ;; and follow the convention. | |||
| (compojure/context | |||
| "/ee" [] | |||
| (compojure/context | |||
| "/billing" [] | |||
| billing/routes) | |||
| [cheshire.core :as json] | ||
| [clj-http.client :as http] | ||
| [clojure.core.memoize :as memoize] | ||
| [compojure.core :as compojure :refer [GET PUT]] |
There was a problem hiding this comment.
Suggested change
| [compojure.core :as compojure :refer [GET PUT]] | |
| [compojure.core :as compojure :refer [GET]] |
| [metabase.util :as u] | ||
| [metabase.util.i18n :as i18n] | ||
| [toucan2.core :as t2]) | ||
| (:import [com.fasterxml.jackson.core JsonParseException])) |
There was a problem hiding this comment.
Suggested change
| (:import [com.fasterxml.jackson.core JsonParseException])) | |
| (:import | |
| (com.fasterxml.jackson.core JsonParseException))) |
|
@qwef Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38197
For #36367
Description
BE used for routing information from the client to harbormaster.