Fixed width dashboard migration #38247

adam-james-v · 2024-01-30T00:12:17Z

This PR addressed the first 2 items in #36358

(BE) Create new width setting on dashboard object with 2 options: "full" | "fixed"

(BE) Create migration to set all existing dashboards to width = "full"

The need was:

add a :width setting on dashboards
the allowed values here are 'fixed' or 'full'
for all new dashboards, the default setting shall be 'fixed' (the new default behaviour we want)
for all existing dashboards, the value should be set to 'full' (the existing behaviour)

3 migrations were used to achieve this:

the migration adding the column, whose default value is 'fixed'. This ensures all new dashboards will have the value correctly set
another migration to change all existing dashboard entries to have the 'full' value. This makes sense as it won't break existing behaviours for users
the final migration setting the width column to notNull, ensuring it's always set going forward.

A test was added to the Dashboard api test namespace to make sure these properties are met after the migration.

I've also manually tested in the REPL:

;; an existing dashboard:
(:width (t2/select-one :model/Dashboard))
;; full.

;; a newly created dashboard:
(:width (t2/select-one :model/Dashboard :id 535))
;; fixed.

The setting is exposed to change via PUT /api/dashboard/:id.

3 migrations: - 1st adding the width column with default value of 'fixed' - 2nd updating all existing dashboards to have width 'full', which corresponds to what the current behaviour is (will be the 'old' behaviour after the fixed-width project lands). - The rolloback here is necessary but we don't care what happens as the column will be dropped immediately in the next rollback anyway - 3rd sets the notNullableConstraint. DefaultNull is 'full' here, just in case there's an existing dashboard whose width value is not yet set from the 1st migration. Don't know how that could happen, but its here in case

update-dashboard function now is aware of the :width key so those changes can end up in the transaction. Also added a width test that asserts that the value's default is "fixed", it can be changed, eg. to "full", but cannot be changed to other values.

replay-io · 2024-01-30T00:58:21Z

Status	In Progress ↗︎ 36 / 52
Commit	`19f01a9`
Results	❌ 1 Failed should work for longitude AssertionError: Timed out retrying after 4000ms: Unable to find an element with the text: Saved Questions. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible. Ignored nodes: comments, <script />, <style /> <html lang="en" translate="no" > <head> <meta charset="utf-8" /> <meta content="IE=edge" http-equiv="X-UA-Compatible" /> <meta cont... ⚠️ 3 Flaky should allow non-user to unsubscribe from subscription should order columns correctly in unsaved native query exports should validate approved email domains for a question alert in the audit app ✅ 1578 Passed 'block' data permission should not have editable 'native query editing' option (metabase#17738) 'contains' filter should still work after title drill through IF the native question field filter's type matches exactly (metabase#16181) 'contains' filter should still work after title drill through IF the native question field filter's type matches exactly (metabase#16181) 'distribution' should work on a joined table from a saved question (metabase#14787) 'Invite someone' button shouldn't be covered/blocked on smaller screen sizes (metabase#16350) 'read-only' user should be able to resize column width (metabase#9772) 'Saved Questions' prompt should respect nested collections structure (metabase#14178) "COMPARE TO THE REST" should not show NULL in titles of generated dashboard cards (metabase#15737) "COMPARE TO THE REST" should work on a nested question made from base native question (metabase#15655) "X-RAY" should not show NULL in titles of generated dashboard cards (metabase#15737) "X-RAY" should work on a nested question made from base native question (metabase#15655) abandoning archive process should keep you in the same collection (metabase#15289) abandoning archive process should keep you in the same collection (metabase#15289) abandoning archive process should keep you in the same collection (metabase#15289) adding question to one dashboard shouldn't affect previously visited unrelated dashboards (metabase#26826) adds a contains text filter adds a custom query action to a dashboard and runs it adds a custom query action to a dashboard and runs it adds a query action and runs it adds a query action and runs it adds an ends with text filter adds an implicit action and runs it adds an implicit action and runs it adds an implicit create action to a dashboard and runs it adds an implicit create action to a dashboard and runs it adds an implicit delete action to a dashboard and runs it adds an implicit delete action to a dashboard and runs it adds an implicit update action to a dashboard and runs it adds an implicit update action to a dashboard and runs it adds and removes bookmarks from Model in collection adds filters to url as get params and renders the results correctly (metabase#7120, metabase#17033, metabase#21993) adds multiple is text filters admin user can create a snippet (metabase#21581) after removing the last group redirects to the home page allows 'Custom mapping' null values allows accessing tools, audit, and troubleshooting for non-admins allows admins to see the instance analytics collection content allows changing data model permission for an entire database allows data model permission for a table in database allows database managers to see and edit database details but not to delete a database (metabase#22293) allows editing sandboxed access in the database focused view allows editing sandboxed access in the group focused view allows editing settings as a non-admin user allows for canceling changes allows for canceling changes allows for canceling changes allows opening custom URL destination that is not a Metabase instance URL using link (metabase#33379) allows opening custom URL destination with parameters allows setting dashboard tab with parameter as custom destination allows setting dashboard with multiple parameters as custom destination allows setting dashboard with single parameter as custom destination allows setting dashboard without filters as custom destination and changing it back to default click behavior allows setting saved question as custom destination and changing it back to default click behavior allows setting saved question with multiple parameters as custom destination allows setting saved question with single parameter as custom destination allows setting URL as custom destination and changing it back to default click behavior allows setting URL with parameters as custom destination allows switching to the granular access and update table permissions allows to create a question based on a model allows to delete alerts allows to delete subscriptions allows to edit action query and parameters in action execute modal allows to edit action query and parameters in action execute modal allows to edit action title and field placeholder in action execute modal allows to edit action title and field placeholder in action execute modal allows to edit GUI model query allows to edit native model query allows to edit recipients allows to edit recipients allows to only view Administrators permissions (Replay 1, Replay 2) allows to select an item from keyboard allows to turn a GUI question into a model allows to turn a model back into a saved question allows to turn a native question into a model allows to undo turning a question into a model allows to view and edit permissions (Replay 1, Replay 2) allows updating multiple dashboard filters allows updating multiple dashboard filters allows updating single dashboard filter and changing it back to default click behavior allows view and edit permissions (Replay 1, Replay 2) allows view and edit permissions (Replay 1, Replay 2) applies a between filter applies a greater than filter archived subcollection should not show up in permissions (metabase#19603) archiving sub-collection should redirect to its parent archiving sub-collection should redirect to its parent archiving sub-collection should redirect to its parent attempt to sandbox based on question with differently-typed columns than a sandboxed table should provide meaningful UI error (metabase#14612) autocomplete should complete question slugs inside template tags autocomplete should work for columns from referenced questions behavior is updated after linked dashboard filter has been removed can add a date shortcut filter can add a date shortcut filter from the popover can add, update bookmark name when collection name is updated, and remove bookmarks from collection from its page can add/remove bookmark from pinned Question in collection can add/remove bookmark from pinned Question in collection can add/remove bookmark from unpinned Dashboard in collection can add/remove bookmark from unpinned Question in collection can apply a filter from a searched column can browse to a database can browse to a model Can cancel adding date filter can create a custom column (metabase#13241) can create a custom column with an existing column name can create a question by filtering and summarizing a model can create a question using table click actions can edit model info can insert various data types via implicit actions can insert various data types via implicit actions can load a question with a date filter (metabase#12228) can manage groups from the group page can manage members from the people page can query MySQL database can remove bookmark from item in sidebar can save a native MongoDB query can save a native MySQL query can save a question with no rows can search for a column can see x-ray options when a custom column is present (#16680) can set cache ttl for a saved question can set cache ttl for a saved question can set impersonated permissions can show object detail modal for items with composite keys can show object detail modal for items with composite keys can show object detail modal for items with no primary key can show object detail modal for items with no primary key can submit query action linked with dashboard parameters (metabase#32974) can toggle bookmark list visibility can update various data types via implicit actions can update various data types via implicit actions Can upload a CSV file to an empty postgres schema Can upload dog_breeds.csv to a collection Can upload star_wars_characters.csv to a collection can view a public object detail question can view an object detail question on a public dashboard can view summary of model's last edit can visit 'Learn about our data' page can write a native MySQL query with a field filter cannot add bookmark to root collection cannot edit details for personal collections nor change permissions for personal collections or sub-collections (metabase#8406) cannot navigate past the end of the list of objects with the keyboard cannot navigate past the end of the list of objects with the keyboard Cannot upload invalid.csv to a collection card parameter defaults should apply for disabled parameters, but not for editable or locked parameters card parameter defaults should apply for disabled parameters, but not for editable or locked parameters card reference tags should update when the name of the card changes changes model's display to table changes should reflect on admin's dashboard changes should reflect on user's dashboard changes should reflect while signed out clears custom metadata when a model is turned back into a question clicking 'Explore results' works (metabase#32121) collection opens modal and redirects to a created collection after saving collections list on the home page shouldn't depend on the name of the first 50 objects (metabase#16784) column from a nested aggregation with column column from a nested aggregation with column column from a nested aggregation with column column from a nested aggregation without column column from a nested aggregation without column column from a nested aggregation without column column from a nested breakout column from a nested breakout column from a nested breakout column from a question column from a question column from a table column from an explicit join column from an explicit join column from an explicit join column from an explicit join with fields column from an explicit join with fields column from an explicit join with fields column from an expression based on a question column column from an expression based on a question column column from an expression based on another table column column from an implicit join column from an implicit join with fields column from an implicit join with fields column reordering should work (metabase#16229) composite keys should act as filters on click (metabase#13717) convert GUI question to native query, and 'Explore results' works (metabase#32121) converting a question to the native query should pre-select a table (metabase#15946) correctly serializes exclude filter on non-English locales (metabase#29122) Count of rows AND Sum of VAL by CAT (metabase#15725-1) Count of rows by CAT + add sum of VAL later from the sidebar (metabase#15725-2) creates a native query model via the New button creates snapshots for supported qa databases (Replay 1, Replay 2, Replay 3, Replay 4, Replay 5, Replay 6, Replay 7, Replay 8, Replay 9, Replay 10, Replay 11, Replay 12, Replay 13, Replay 14, Replay 15, Replay 16, Replay 17, Replay 18, Replay 19, Replay 20, Replay 21, Replay 22, Replay 23, Replay 24, Replay 25, Replay 26) custom expression aggregation should work in metrics (metabase#22700) custom expression names (metabase#16249-1) dashboard click behavior works without tabId previously saved dashboard filter connected to the field filter should work with a single value in embedded dashboards (metabase#20438) dashboard filters should work on nested question (metabase#12614, metabase#13186, metabase#18113, metabase#32126) dashboard linked filters values doesn't work in static embed preview (metabase#37914) dashboard should handle cards with null values (metabase#13801) dashboard should have the correct embed snippet dashboard should have the correct embed snippet DASHBOARD: locked parameter should work with numeric values (metabase#25031) DASHBOARD: locked parameter should work with numeric values and the required filter with the default value (metabase#25031) data selector popover should not be too small (metabase#15591) database actions sidebar database settings default (Replay 1, Replay 2, Replay 3, Replay 4, Replay 5, Replay 6, Replay 7, Replay 8, Replay 9, Replay 10, Replay 11, Replay 12, Replay 13, Replay 14, Replay 15, Replay 16, Replay 17, Replay 18, Replay 19, Replay 20, Replay 21, Replay 22, Replay 23, Replay 24, Replay 25, Replay 26) DEFAULT version: drill-through should work on implicit joined tables with sandboxes (metabase#13641) DEFAULT version: should work on questions with joins, with sandboxed target table, where target fields cannot be filtered (metabase#13642) display the relevant error message in save question modal (metabase#21597) display value 'custom mapping' should be available regardless of the chosen filtering type (metabase#16322) displays an error displays an error when running selected text displays official badge throughout the application displays parameter field on desktop and mobile displays trendline when there are multiple numeric outputs (for simple question) (metabase#12781) distinct inside custom expression should suggest non-numeric types (metabase#13469) does not allow accessing tools, audit, and troubleshooting for non-admins does not allow opening custom dashboard destination does not allow opening custom question destination does not allow setting dashboard as custom destination if user has no permissions to it does not allow setting saved question as custom destination if user has no permissions to it does not allow to set click behavior for object detail dashcard does not allow to set click behavior for virtual dashcards does not allow updating dashboard filters if there are none does not show json, enum, or binary columns for implicit actions does not show json, enum, or binary columns for implicit actions does not show model actions in model visualization on a dashboard Don't bin don't propagate permissions by checkbox without access select (Replay 1, Replay 2) editing an alert should not delete it (metabase#17547) educational screen should show for the first alert, but not for the second educational screen should show for the first alert, but not for the second filters by a foreign key filters by primary keys frontend should gracefully handle the case of a subscription without a recipient (metabase#17657) gives ability to create dashboard subscriptions gives ability to create question alerts handles failing queries have limited access hidden table should not show up in various places in UI hould allow you to reorder and show/hide rows impersonation modal should be positioned behind the page leave confirmation modal infers a <= filter from an invalid between filter invite member when SSO is configured metabase#23630 invite member when SSO is not configured it should show the notification for other users after one user dismissed it it should validate the url joining on a question with remapped values should work (metabase#15578) lets user download results from native queries lets you change field name and description lets you change field visibility lets you change to 'Search box' lets you change to 'Use foreign key' and change the target for field with fk lets you create and run a SQL question lets you enable/disable 'Unfold JSON' for JSON columns limit list options based on linked filter limit search options based on linked filter limits download results for a native question even if only one table has `limited` download permissions limits users from downloading all results loads metadata when it is not cached (metabase#23510) locks display to table login history tab should be available with google_auth enabled (metabase#15558) login history tab should be available with ldap_auth enabled (metabase#15558) model based on multi-level nested saved question should work (metabase#22859-1) models metadata tab should show columns with details-only visibility (metabase#22521) moving collections should update the UI (metabase#14280, metabase#14482) needs a default value for to run or save query needs a default value to run or save the query needs a default value to run or save the query needs a default value to run or save the query nested questions based on a saved question with joins should work (metabase#14724) new dashboard UI flow new question data picker search should work for both saved questions and database tables nocollection user should be able to view and unsubscribe themselves from a subscription nodata user should not see 'Explore results' (metabase#20044) nodata user should not see the blank screen when visiting model (metabase#20042) NODATA+NOSQL version: should be able to view SQL question when accessing via dashboard with filters connected to modified card without SQL permissions (Cannot view SQL question when accessing via dashboard with filters connected to modified card without SQL permissions #15163) normal user can create a snippet (metabase#21581) NORMAL version: advanced sandboxing should not ignore data model features like object detail of FK (metabase-enterprise#520) NOSQL version: should be able to view SQL question when accessing via dashboard with filters connected to modified card without SQL permissions (Cannot view SQL question when accessing via dashboard with filters connected to modified card without SQL permissions #15163) opens a dashboard audit page when question title clicked opens a question audit page when question title clicked opens a user audit page when question title clicked opens a user audit page when question title clicked pie chart should handle `0`/`null` values (metabase#13626) pinning should work properly for both questions and dashboards pinning should work properly for both questions and dashboards pinning should work properly for both questions and dashboards popover should not be scrollable horizontally (metabase#31339) postgres should display pivot tables (metabase#14148) prevents user from downloading a native question even if only one table doesn't have download permissions properly loads and updates date and time fields for implicit update actions properly loads and updates date and time fields for implicit update actions question field filter shows all tables from a selected database (metabase#19451) question item opens question notebook editor question item opens SQL query editor question should have the correct embed snippet question should have the correct embed snippet QUESTION: locked parameter should work with numeric values (metabase#20845) QUESTION: locked parameter should work with numeric values and the required filter with the default value (metabase#20845) redirects to /model URL when opening a model with /question URL refetches form values when id changes (metabase#33084) regular column names (metabase#16249-2) REMAPPED version: drill-through should work on implicit joined tables with sandboxes (metabase#13641) REMAPPED version: should work on questions with joins, with sandboxed target table, where target fields cannot be filtered (metabase#13642) removes items from bookmarks list when they are archived removing all aggregations should show add aggregation button with label replace missing values with "Nothing" should work on Mongo (metabase#16170) replace missing values with "Zero" should work on Mongo (metabase#16170) respects 'no download' permissions when 'All users' group data permissions are set to `Block` (metabase#22408) restricts users from downloading questions revokes ability to create subscriptions and alerts and manage them sandboxed user should receive sandboxed dashboard subscription saving a dashboard should track a 'dashboard_saved' snowplow event SB question with `case` CC should substitute the `else` argument's table (metabase#14859) selected dimensions becomes pinned to the top of the dimensions list selected dimensions from another table includes the table alias when becomes pinned to the top selecting a binning adds a dimension setting downloads permission UI flow should work should add a filter should add a filter for a raw query should add a filter for an aggregated query should add a filter for linked tables should add key attributes to a new user should add key attributes to an existing user should add Mongo database and redirect to listing should add Mongo database via the connection string should add MySQL database and redirect to listing should add Postgres database and redirect to listing (metabase#12972, metabase#14334, metabase#17450) should add, update bookmark name when dashboard name is updated, and then remove bookmark should add, update bookmark name when question name is updated, then remove bookmark from question page should allow 'Distribution' and 'Sum over time' on nested questions (metabase#12568) should allow 'zoom in' drill-through when grouped by custom column (metabase#13289) (metabase#13289) should allow a nodata user to select the filter should allow a user with no data access to execute a native subquery should allow action execution from the model detail page should allow action execution from the model detail page should allow adding models to dashboards should allow admin to create new users should allow admin to create new users without first name or last name (metabase#22754) should allow admin to deactivate and reactivate other admins/users should allow an admin user to select the filter should allow brush date filter should allow changing column title when the field ref is the same except for the join-alias should allow changing the field description should allow changing the field description should allow changing the field foreign key target should allow changing the field foreign key target should allow changing the field foreign key target should allow changing the field name should allow changing the field name should allow changing the field name with data model permissions only in field settings should allow changing the field name with data model permissions only in table settings should allow changing the field semantic type and currency should allow changing the field semantic type and currency should allow changing the field visibility should allow changing the field visibility should allow changing the table description should allow changing the table name should allow changing the table name with data model permissions only should allow changing the table visibility should allow choosing a suggestion with Tab should allow clearing the field description should allow clearing the table description should allow clicking on a legend in a native question without breaking the UI (metabase#12439) should allow converting questions with static snippets to models (metabase#20963) should allow creating an API key should allow creating questions and dashboards with an API key should allow creation of a new email subscription should allow creation, editing, and saving of heading component should allow creation, editing, and saving of text boxes should allow CRUD operations on model actions should allow customising the help link should allow dashboard filters to be connected to tags in text cards should allow data settings to be changed and display should reflect changes should allow deleting an API key should allow deleting mappings along with deleting, or clearing users of, mapped groups should allow deleting mappings along with deleting, or clearing users of, mapped groups should allow deleting mappings along with deleting, or clearing users of, mapped groups should allow deleting mappings with groups, while keeping remaining mappings consistent with their undeleted groups should allow deleting mappings with groups, while keeping remaining mappings consistent with their undeleted groups should allow deleting mappings with groups, while keeping remaining mappings consistent with their undeleted groups should allow display settings to be changed and display should reflect changes should allow dots in the variable reference (metabase#15029) should allow drill-through for sandboxed user (metabase-enterprise#535) should allow drills on FK columns should allow drills on FK columns from dashboards should allow editing an API key should allow editing dashcard series when added series are broken (metabase#22265) should allow editing questions and dashboards with an api key should allow empty card title (metabase#12013, metabase#36788) should allow for setting parameters in subscription should allow group creation and deletion should allow hiding and restoring all tables in a schema should allow implicit action execution from the model details page should allow implicit action execution from the model details page should allow join based on native query (metabase#29795) should allow joins to the sandboxed table (metabase-enterprise#154) should allow joins with multiple conditions should allow login regardless of login email case should allow making card hide when it is empty should allow me to rearrange long tabs (#34970) should allow moving dashcard even if we don't have permission on that underlying query should allow moving dashcards between tabs should allow moving different types of dashcards to other tabs should allow navigating back to the list of timelines should allow navigating to the notebook editor directly from a dashboard card should allow non-user to undo-unsubscribe from subscription should allow paginating group members forward and backward should allow paginating people forward and backward should allow public sharing of actions and execution of public actions should allow public sharing of actions and execution of public actions should allow public sharing of implicit action and execution should allow public sharing of implicit action and execution should allow public sharing of query action and execution should allow public sharing of query action and execution should allow query action execution from the model details page should allow query action execution from the model details page should allow regenerating an API key should allow reverting to a saved question state and back into a model again should allow setting column relations (metabase#29318) should allow setting dashboard and saved question as custom destination for different columns should allow setting dashboard tab with parameter for a column should allow setting foreign key mapping for accessible tables should allow setting URL as custom destination and updating dashboard filters for different columns should allow settings click behavior on boolean fields (metabase#18067) should allow sharing if dashboard contains only text cards (metabase#15077) should allow sharing if there are no dashboard cards should allow sorting fields alphabetically should allow sorting fields as in the database should allow sorting fields in the custom order should allow sorting fields smartly should allow subsequent joins and nested query after summarizing on the implicit joins (metabase#20519) should allow switching between different pages for a pinned question (metabase#23515) should allow switching between multiple schemas for x-rays should allow switching focus with Tab should allow tabbing away from, then back to editor, while formatting expression and placing caret after reformatted expression should allow to change sub-collections permissions after access change (metabase#20911) should allow to convert a structured query to a native query should allow to create a new question from the navbar (metabase#21511) should allow to create an action with the New button should allow to disable and enable google auth (metabase#20442) should allow to disable and enable jwt should allow to disable and enable ldap should allow to disable and enable saml should allow to display any column as link with extrapolated url and text should allow to navigate back and forth should allow to pick a saved question when there are models should allow to preview a fully parameterized query should allow to regenerate the jwt key and save the settings should allow to reset google settings should allow to reset jwt settings should allow to reset ldap settings should allow to reset saml settings should allow to save and enable jwt should allow to save and enable saml should allow to search people should allow to sort unpinned items by columns asc and desc should allow to update saml settings should allow to x-ray models from collection views should allow toggling of Remember Me should allow toggling of the total bar should allow toggling of value labels should allow toggling the sidebar should allow undoing a tab deletion should allow user login on EE when LDAP is enabled should allow user login on OSS when LDAP is enabled should allow user to unarchive, delete, and undo archive of items should allow users to add link cards to dashboards should allow users to create public dashboards should allow users to paginate results should allow users to provide internal urls should allow using `Custom Expression` in orders metrics (metabase#12899) should allow using models in native queries should allow using strings in filter based on a custom column (metabase#13751) should allow you to change field formatting should allow you to re-order columns even when one has been removed (metabase #14238, #29287) should allow you to remove a column and add two foreign columns should allow you to reorder and hide columns in the table header should allow you to show/hide and reorder columns should always be possible to view the full title text of the saved question should appear after a field reference should appear in audit log (metabase#16845 metabase-enterprise#486) should appear in audit log (metabase#29456) should appear while inside a function should apply a boolean filter should apply and remove segment filter should apply brush filters by dragging map should apply brush filters to the series selecting area range when axis is a number should apply correct date range on a graph drill-through (metabase#13785) should apply correct font should apply default of the SQL field filter if the dashboard doesn't have a filter connected to it should apply default of the SQL field filter if the dashboard filter is empty should apply filter and show loading spinner when changing tabs (#33767) should apply filters after clicking the apply button when auto-apply filters is turned off should apply filters after clicking the apply button when auto-apply filters is turned off should apply filters after clicking the apply button when auto-apply filters is turned off should apply metrics including filter to the nested question (metabase#12507) should archive a timeline and undo should archive an event from the timeline and undo should archive an event when editing this event should archive and delete a timeline should archive and unarchive a timeline should archive and unarchive an event should automatically hide the visualization for pinned native questions with missing required parameters should automatically pin newly created models should be able to access the question's revision history via the revision history button in the header of the query builder should be able to access the question's revision history via the revision history button in the header of the query builder should be able to add a date range filter to a custom column should be able to add new columns after hiding some (metabase#15393) should be able to archive a pinned dashboard should be able to archive/unarchive a dashboard should be able to archive/unarchive a dashboard should be able to archive/unarchive a dashboard should be able to archive/unarchive dashboard should be able to archive/unarchive dashboard should be able to archive/unarchive dashboard should be able to archive/unarchive model should be able to archive/unarchive model should be able to archive/unarchive question (metabase#15253) should be able to archive/unarchive question (metabase#15253) should be able to archive/unarchive question (metabase#15253) should be able to change title and description should be able to change title and description should be able to change title and description should be able to change y axis position (metabase#13487) should be able to choose a child collection when saving a question (metabase#14052) should be able to click the title of an x-ray dashcard to see it in the query builder (metabase#19405) should be able to compare two fields using filter expression (metabase#17963) should be able to do subsequent aggregation on a custom expression (metabase#14649) should be able to do subsequent joins on question with the aggregation that uses implicit joins (metabase#17767) should be able to drag an item to the root collection (metabase#16498) should be able to duplicate a pinned dashboard should be able to duplicate the dashboard without obstructions from the modal (metabase#15256) should be able to duplicate the dashboard without obstructions from the modal (metabase#15256) should be able to duplicate the dashboard without obstructions from the modal (metabase#15256) should be able to edit collection(s) inside personal collection should be able to edit collection(s) inside personal collection should be able to edit collection(s) inside personal collection should be able to edit collection(s) inside personal collection should be able to edit collection(s) inside personal collection should be able to edit collection(s) inside personal collection should be able to edit collection(s) inside personal collection should be able to edit collection(s) inside personal collection should be able to edit collection(s) inside personal collection should be able to edit tables permissions in granular view after "block" permissions (metabase#17763) should be able to format data point values style independently on multi-series chart (metabase#13095) should be able to hide the visualization for a pinned question should be able to join two saved questions based on the same table (metabase#18502) should be able to manage collection authority level should be able to move a pinned dashboard should be able to move/undo move a dashboard (metabase#13059, metabase#25705) should be able to move/undo move a dashboard (metabase#13059, metabase#25705) should be able to move/undo move a dashboard (metabase#13059, metabase#25705) should be able to open field properties even when one of the tables is hidden (metabase#18384) should be able to open x-ray on a dashcard from a dashboard with multiple tabs should be able to pin a dashboard should be able to pin a model should be able to pin a pivot table should be able to pin a question should be able to pin a visualization by dragging it up should be able to publish/embed and then unpublish a dashboard without filters (Replay 1, Replay 2) should be able to publish/embed and then unpublish a question without filters (Replay 1, Replay 2) should be able to reference a nested question (metabase#25988) should be able to reference a saved native question that ends with a semicolon `;` (metabase#28218) should be able to remove columns via QB sidebar / settings (metabase#14841) should be able to rename table columns via popover should be able to revert the question via the action button found in the saved question timeline should be able to revert the question via the action button found in the saved question timeline should be able to run update and delete actions when enabled for a admin user should be able to run update and delete actions when enabled for a normal user should be able to sandbox using query builder saved questions should be able to save a question to a collection created on the go should be able to save an x-ray as a dashboard and visit it immediately (metabase#18028) should be able to save and clear email settings should be able to save metadata changes with empty description (metabase#20517) should be able to search model index values and visit detail records should be able to see alerts notifications should be able to see details of a record outside the first 2000 should be able to see details of each table should be able to see help info should be able to see help info should be able to see pulses notifications should be able to see that a question has been verified but can't moderate the question themselves should be able to select and update a field in a database without schemas should be able to select and update a table in a database without schemas should be able to show a column from a nested query when it was hidden in the notebook editor should be able to show and hide all table fields with a single click should be able to show and hide columns from a nested query with a self join should be able to show and hide columns from aggregations should be able to show and hide columns from aggregations from a nested query should be able to show and hide custom expressions for a table should be able to show and hide custom expressions for a table with selected fields should be able to show and hide custom expressions from a joined question should be able to show and hide custom expressions from a nested query should be able to show and hide fields from a nested native query should be able to show and hide fields from a nested query should be able to show and hide fields from a nested query with joins (metabase#32373) should be able to show and hide fields from a nested query with joins and fields (metabase#32373) should be able to show and hide implicitly joinable fields for a nested query should be able to show and hide implicitly joinable fields for a nested query with joins and fields should be able to show and hide implicitly joinable fields for a table should be able to show and hide table fields should be able to show and hide table fields in a multi-stage query should be able to show and hide table fields with a join with fields should be able to show and hide table fields with a self join with fields should be able to show and hide table fields with in a join should be able to show the visualization for a pinned question should be able to toggle public sharing should be able to unpin a pinned dashboard should be able to unsubscribe and delete a pulse when the user has created it should be able to unsubscribe and delete an alert when the user created it should be able to unsubscribe from an alert when the user has not created it should be able to update the bucket size / granularity on a field that has sorting applied to it (metabase#16770) should be able to use a custom column in aggregation for a nested query (metabase#18814) should be able to use a native question source should be able to use a native question source in the query builder should be able to use a native question source when embedded should be able to use a native question source when embedded should be able to use a native question source when embedded with a text tag should be able to use a native question source when public should be able to use a native question source when public should be able to use a native question source when public with a text tag should be able to use a static list source should be able to use a static list source in the query builder should be able to use a static list source when embedded should be able to use a static list source when embedded should be able to use a static list source when public should be able to use a static list source when public should be able to use a structured question source should be able to use a structured question source should be able to use a structured question source when embedded should be able to use a structured question source when embedded should be able to use a structured question source when embedded with a text tag should be able to use a structured question source when public should be able to use a structured question source when public should be able to use a structured question source when public with a text tag should be able to use a structured question source with a text tag should be able to use a structured question source without saving the question should be able to use aggregation functions on saved native question (metabase#15397) should be able to use custom expression after aggregation (metabase#13857) should be able to use search box with fields configured for list should be able to use summarize columns from joined table based on a saved question (metabase#14766) should be able to use typeahead search functionality should be able to use typeahead search functionality should be able to verify and unverify a saved question should be able to view public dashboards should be able to view public dashboards should be able to view public dashboards should be able to view public questions should be able to view public questions should be able to view public questions with card template tags should be able to view public questions with snippets should be able to view their own as well as other users' personal collections (including other admins) should be able view other users' personal sub-collections (metabase#15339) should be disabled by default but able to be set to editable and/or locked (metabase#20357) should be offered to duplicate dashboard in collections they have `read` access to should be offered to duplicate dashboard in collections they have `read` access to should be okay showing an empty joined table (metabase#29140) should be possible to apply bulk selection to all items (metabase#14705) should be possible to bulk archive items (metabase#16496) should be possible to bulk move items and undo should be possible to convert a question with an aggregation and breakout into a model should be possible to create a question based on a question in another user personal collection should be possible to disable downloads should be possible to scroll vertically after fullscreen layer is closed (metabase#15596) should be possible to sort by metric (metabase#8283) should be possible to sort on the breakout column (metabase#30743) should be possible to switch beteween 'People' and 'Groups' tabs and to add/remove users to groups (metabase-enterprise#210, metabase#12693, metabase#21521) should be possible to update/change label for an empty row value (metabase#12128) should be possible to use ID filter on a nested question (metabase#17212) should be possible to visit a dashboard with click-behavior linked to the dashboard without permissions (metabase#15368) should be possible via questions sidebar should be runnable with the None filter being ignored (metabase#20643) should be supported for raw data question should be supported for timeseries question without a goal should be usable on mobile screen sizes (metabase#15006) should be usable on small screens should call the autocompleter eventually, even when only 1 character was typed (metabase#34330) should call the autocompleter when backspacing to a 1-character prefix(metabase#34330) should cancel the native query via the keyboard shortcut (metabase#11727) should catch non-existent field reference should change a boolean filter should change last editor when another user changes item should change to column formatting when sidebar is already open (metabase#16043) should clean up selection when opening another collection (metabase#16491) should clear a template tag's default value when the type changes (metabase#11480) should correctly accept the chosen field suggestion should correctly accept the chosen function suggestion should correctly apply and display custom remapping for numeric values should correctly apply breakout in query builder (metabase#14648) should correctly apply distinct count on multiple columns (metabase#13097) should correctly display a revision state after a restore (metabase#12581) should correctly display deep nested collections with long names should correctly display tooltip values when X-axis is numeric and style is 'Ordinal' (metabase#15998) should correctly drill-through on Orders filter (metabase#11503-1) should correctly drill-through on Products filter (metabase#11503-2) should correctly fetch field values for a filter when native question is used for sandboxing (metabase#24966) should correctly filter custom column by 'Not equal to' (metabase#14843) should correctly filter the table with a number parameter mapped to the custom column Quantity_2 should correctly insert function suggestion with the opening parenthesis should correctly order joins for MySQL queries (metabase#15342) should correctly show native models for no-data users should correctly show remapped column value should create a nested question with post-aggregation filter (metabase#11561) should create an additional timeline should create an event in a personal collection should create an event with date should create an event with date and time should create an event with date and time at midnight should create an event with description should create an event within the default timeline should create custom column with fields from aggregated data (metabase#12762) should create new collections within the current collection should create new dashboard inside a collection created on the go should create the first event and timeline should create the first event and timeline should create, delete, and re-create a model index on product titles should deep duplicate a dashboard and its cards should deep duplicate a dashboard and its cards should deep duplicate a dashboard and its cards should deep duplicate a dashboard and its cards to a collection created on the go should deep duplicate a dashboard and its cards to a collection created on the go should deep duplicate a dashboard and its cards to a collection created on the go should default to saving audit content in custom reports collection should delete an event should delete dashboard subscription from any collection (metabase#17658) should disable home link when top nav is enabeld but side nav is disabled should disable the embed button for card and provide a tooltip should disable the embed button for dashboard and provide a tooltip should disallow admin to create new users with case mutation of existing user should disallow admin to deactivate themselves should display a back to the dashboard button in model x-ray dashboards should display a back to the dashboard button in table x-ray dashboards should display a back to the dashboard button when navigating to a question should display a badge next to official questions in regular dashboards should display a link to the interactive embedding settings should display a link to the product page for embedded analytics should display a pin map for a native query should display a row chart should display a toast when a dashboard takes longer than 15s to load should display a toast when a dashboard takes longer than 15s to load should display a toast when a dashboard takes longer than 15s to load even without parameter values (but has parameters with default values) should display a tooltip for a grid map without a metric column (metabase#17940) should display a tooltip for CTA icons on an individual question (metabase#16108) should display according to `locale` parameter metabase#22561 should display all events in data view should display all visualization cards with their default sizes should display an error for incorrect passwords should display an error if they don't have perms for the dashboard should display an error message when there are more series than the chart supports should display and work with enabled parameters while hiding the locked one should display api keys included in a group and display a warning when deleting the group should display breakouts group for all FKs (metabase#36122) should display column options for cross-filter (metabase#14473) should display correct axis labels (metabase#12782) should display correct data values should display correct number of orders should display correct permissions on the database level after changes on the table level (metabase#20436) should display correct tooltip value for multiple series charts on dashboard (metabase#15612) should display correct values when one of them is 0 (metabase#16246) should display custom column regardless of how many columns are selected (metabase#20229) should display dashboards with some cards locked down should display date granularity on Summarize when opened from saved question (metabase#10441, metabase#11439) should display error on failed save (Replay 1, Replay 2) should display GUI question with explicit joins correctly should display if user is the last editor should display last edit moment for dashboards should display last edit moment for questions should display last editor's name should display more than 50 groups (metabase#17200) should display nested snippets in a flat list (Replay 1, Replay 2) should display nested snippets in their folder should display parameters for variable template tags only should display popular items for a new user should display questions belonging to previously official collections as regular in regular dashboards should display recent items should display rows whose value is `null` (metabase#13571) should display same error for unknown users (to avoid leaking the existence of accounts) should display the embedding page correctly (Replay 1, Replay 2) should display the GUI question with aggregation correctly should display the nested GUI question correctly should display the order of the settings items consistently between OSS/EE versions (metabase#15441) should display the permissions screen on /admin should display the permissions screen on /collection/3 should display the permissions screen on /dashboard/8 should display the permissions screen on /question/76 should display the regular GUI question correctly should display the toast indefinitely unless dismissing manually should display total runtime correctly (metabase#18317) should display trend line for stack-100% chart (metabase#25614) should display x-rays for a user database should display x-rays for the sample database should drill-through correctly when stacking should drill-through on a foreign key (metabase#8055) should drill-through on a primary key out of 2000 rows should drill-through on PK/FK to the "object detail" when filtered by explicit joined column (metabase#15331) should drop custom column (based on a joined field) when a join is removed (metabase#14775) should duplicate a saved question should duplicate a saved question to a collection created on the go should edit a timeline should edit an event should edit an event should edit existing user details should edit GUI model metadata should edit native model metadata should enable alert to be updated (without updating question) (metabase#36866) should expand the native editor when editing a question from a dashboard should fail on expression validation errors should fall back to the first tab after target dashboard tab has been removed and there is only 1 tab left should filter by clicking on the row with `null` value (metabase#18386) should filter out null values (metabase#16049) should forward non-admin users to add email form when clicking add should forward non-admin users to add slack form when clicking add should give you the option to set a custom home page in settings should give you the option to set a custom home page using home page CTA should gracefully handle removing filtered items, and adding new items to the end of the list should greet users after successful login should group by a custom column and work in a nested question (metabase#23862) should handle (removing) multiple metrics when one is sorted (metabase#12625) should handle a failure to `GET` the list of all databases (metabase#20471) should handle ad-hoc question with old syntax (metabase#15372) should handle brackets in the name of the custom column (metabase#15316) should handle CASE (metabase#13122) should handle cc with the same name as an aggregation function (metabase#21513) should handle cc with the same name as the table column (metabase#21135) should handle COALESCE should handle dashboard click through on a table should handle data sets that contain only null values for longitude/latitude (metabase#18061-1) should handle data sets that contain only null values for longitude/latitude (metabase#18061-2) should handle data sets that contain only null values for longitude/latitude (metabase#18061-3) should handle duplicate column names in nested queries (metabase#10511) should handle identical custom column and table column names (metabase#14255) should handle joins on different stages should handle malformed (null) database details (metabase#25715) should handle non-existing databases (metabase#11037) should handle question click through on a table should handle questions with limited permissions should handle remapped display values in a base QB question (metabase#10474) should handle row items being filterd out and returned gracefully should handle template tags should handle the use of `regexextract` in a sandboxed table (metabase#14873) should handle toggling auto applying filters on and off should handle toggling auto applying filters on and off should handle up to 3 comparisons should handle URL click through on a table should handle using `case()` when referencing the same column names (metabase#14854) should have 'Custom expression' in a filter list (metabase#13069) should have 'Send to Slack now' button (metabase#14515) should have a list of the default parameters applied to the subscription should have a scroll bar for long text (metabase#8333) should have default sorting by query runs that can be changed should have different URI while editing the metric should have increase, decrease, and total color options should have no alerts set up initially should have no parameters section should have parameters header occupied the entire horizontal space when visiting a dashboard via navigation (metabase#30645) should hide filters via url should hide main header when there's nothing to display there should hide main header when there's nothing to display there should hide personal collections when adding questions to a dashboard in public collection should hide public collections when selecting a dashboard for a question in a personal collection should hide read-only archived items (metabase#24018) should hide the dashboard header by a param should hide the dashboard header by a param should hide the dashboard's additional info by a param should hide the question header by a param should hide the question's action buttons by a param should hide the question's additional info by a param should hide the side nav by a param should hide the top nav by an explicit param should hide the top nav when nothing is shown should hide the top nav when nothing is shown should hide the Total label if there is no space should include text cards (metabase#15744) should insert data from the correct row in the URL for pivot tables (metabase#17920) should insert values from hidden column on custom destination URL click through (metabase#13927) should instruct user to connect email or slack should interpolate null value by not rendering a data point (metabase#4122) should join a native question (metabase#37100) should join raw tables (metabase#11452, metabase#12221, metabase#13468, metabase#15570) should join saved questions that themselves contain joins (metabase#12928) should join structured questions (metabase#13000, metabase#13649, metabase#13744) should join two saved questions with the same implicit/explicit grouped field (metabase#18512) should keep filter value on blur (metabase#31975) should keep manually entered parenthesis intact if they affect the result (metabase#13306) should keep metadata in sync with the query should keep showing sidebar toggle button when logo, breadcrumbs, the new button, and search are hidden should lead you to a table question with filtered ID (metabase#17213) should leave dashboard if navigating back after initial load should let a user move/undo move a dashboard should let a user move/undo move a dashboard should let a user move/undo move a dashboard should let a user move/undo move a question should let a user move/undo move a question should let a user move/undo move a question should let a user with no data permissions view questions should let admins view all cards in a dashboard should let an admin edit details about the database should let an admin edit details about the metric should let an admin edit the database name should let an admin start to edit and cancel without saving should let an admin start to edit and cancel without saving should let the user create a public link for card should let the user create a public link for dashboard should let the user lock parameters to specific values should let the user navigate to details should let you add a parameter to a dashboard with a text box (metabase#11927) should let you change the field filter type to something else and restore the filter widget (metabase#13825) should let you change the type to 'Foreign Key' and choose the target field should let you change the type to 'No semantic type' should let you click through the title to the query builder (metabase#13042) should let you click through the title to the query builder (metabase#13042) should let you click through the title to the query builder with the parameter applied as a filter on the question should let you click through the title to the query builder with the parameter filter showing in the query builder should let you create a snippet folder and move a snippet into it should let you edit an alert should let you see all created alerts should let you see other alerts where you are a recipient should let you see your own alerts should let you unsubscribe from both your own and others' alerts should link `Get Help` to help should link filters to custom question with filtered aggregate data (metabase#11007) should link to metabase help when the whitelabel feature is disabled (eg OSS) should list existing API keys should load already applied segments should load initially hidden archived items on scroll (metabase#24213) should load question binned by "Month of year" or similar granularity (metabase#16918) should load the collection permissions admin pages should localize date parameters in the instance locale should lock all parameters should modify parameters accordingly when tags are modified should move a timeline should move an event should move an event should move an event and undo should mute items in legend when hovering (metabase#29224) should navigate back to a dashboard with permission errors should navigate effortlessly through collections tree should navigate to a target from a gauge card (metabase#23137) should navigate to a target from a progress card (metabase#23137) should normally open notebook editor for queries joining on custom columns (metabase#18818) should normally open queries with field literals in joins (metabase#18630) should not accidentally delete Custom Column formula value and/or Custom Column name (metabase#15734) should not add query hash on the rerun (metabase#20045) should not allow a nocollection user to visit the page, hence cannot see the filter should not allow action buttons to overflow when editing dashboard should not allow action buttons to overflow when editing dashboard should not allow action buttons to overflow when editing dashboard should not allow action buttons to overflow when viewing info sidebar should not allow action buttons to overflow when viewing info sidebar should not allow action buttons to overflow when viewing info sidebar should not allow cards to be resized smaller than min height should not allow choosing text fields for SUM (metabase#18069) should not allow creating default timelines should not allow creating new events in existing timelines should not allow creating new timelines in collections should not allow creating or editing events should not allow dashboard editing on small screens should not allow editing analytics content (metabase#36228) should not allow editing analytics content (metabase#36228) should not allow indexing when a primary key has been unassigned should not allow links to overflow when editing dashboard should not allow links to overflow when editing dashboard should not allow links to overflow when editing dashboard should not allow links to overflow when viewing saved dashboard should not allow links to overflow when viewing saved dashboard should not allow links to overflow when viewing saved dashboard should not allow moving or archiving analytics collections should not allow navigating back when there is only one timeline in a collection should not allow to run adhoc native questions without permissions should not allow users to provide external urls should not allow you to choose X-axis breakout should not alter visualization type when applying filter on a native question (metabase#17524-1) should not alter visualization type when applying filter on a QB question (metabase#17524-2) should not appear when formula field is not in focus (metabase#15891) should not appear while outside a function should not assign the full name of the state as the filter value on a drill-through (metabase#14650) should not autorun ad-hoc native queries by default should not be able to manage collection authority level for personal collections and their children should not be able to manage collection's authority level should not be able to toggle auto-apply filters toggle should not be able to use bulk actions on collection items (metabase#16490) should not be able to verify a saved question should not be dropped if filter is changed after aggregation (metaabase#14193) should not be offered to edit dashboard details or archive the dashboard for dashboard in collections they have `read` access to (metabase#15280) should not be offered to save dashboard in collections they have `read` access to (metabase#15281) should not be offered to save dashboard in collections they have `read` access to (metabase#15281) should not be possible to create goal based alert for a multi-series question should not be possible to disable downloads should not bin numeric fields in join condition by default (metabase#18589) should not break virtual cards (metabase#35545) should not change the visualization type in a targetted question with mapped filter (metabase#16334) should not crash when searching large field values sets in filters popover (metabase#32985) should not disappear when clicked on (metabase#17548) should not display 'null' day of the week (metabase#14405) should not display a toast even when a dashboard takes longer than 15s to load should not display a toast when a dashboard takes longer than 15s to load if users have no write access to a dashboard should not display data points even when enabled in settings (metabase#13247) should not display disabled parameters should not display duplicate Y-axis after modifying/reordering metrics (metabase#20548) should not display models if nested queries are disabled should not display multiple 'Created At' fields when they are remapped to PK/FK (metabase#15563) should not display official collection icon anymore should not display snippet folder as part of collections (metabase#14907) should not display the same toast twice for a dashboard should not display the toast if there are no parameter values should not display the toast when auto applying filters is disabled should not display the toast when we clear out parameter default value should not display x-rays if the feature is disabled in admin settings (metabase#26571) should not drop fields from joined table on dashboard 'zoom-in' (metabase#27380) should not drop the chart legend (metabase#4995) should not enable 'Done' button before channel is selected (metabase#14494) should not enable subscriptions without the recipient (metabase#17657) should not erase Custom Column formula and Custom Column name on window resize (metabase#16127) should not erase Custom column formula and Custom column name when expression is incomplete (metabase#16126) should not expose database names to which the user has no access permissions (metabase#22695) should not fetch cards that are still loading when refreshing should not flash the homescreen before redirecting (#37089) should not freeze when opening a timeseries chart with sparse data and without the X-axis should not get the parameter values from the field API should not have markdown content overflow the description area (metabase#31326) should not hide custom formatting when click behavior is enabled (metabase#14597) should not hide the top nav when the logo is still visible should not include date when metric is binned by hour of day (metabase#14124) should not invoke API calls for autocomplete twice in a row (metabase#18148) should not let you change the type to 'Number' (metabase#16781) should not let you embed the dashboard (Replay 1, Replay 2) should not let you embed the question (Replay 1, Replay 2) should not let you see other people's alerts should not make the question dirty when there are no changes (metabase#14302) should not offer to reset passwords when password login is disabled should not offer to save question in view only collection (metabase#22727, metabase#20717) should not offer to save question to users with no data permissions should not offer to save the question before it is actually possible to save it (metabase#18148) should not offer to share or embed models (Models should not be shareable (embedding/public) #20815) (Replay 1, Replay 2) should not preserve draft parameter values when editing the dashboard should not preserve query results when the question changes during navigation should not redirect to the value of 'from' URL parameter after saving (metabase#35785) should not reload the model for record in the same model should not remove click behavior on 'reset to defaults' (metabase#14919) should not remove order-by (sort) when changing the breakout field on an SQL saved question (metabase#17975) should not render duplicated columns (metabase#17060) should not render for any other condition (Replay 1, Replay 2) should not render native editor buttons when 'Metadata' tab is open should not render people dropdown outside of the borders of the screen (metabase#17186) should not rerender on gauge arc hover (metabase#15980) should not reset previously populated fields when validation fails for just one of them (metabase#16226) should not return same results for columns with the same name (metabase#12649) should not search on an empty string should not see collection type field if not admin should not see question nor dashboard revert buttons (metabase#13229) should not send snowplow events when enabling auto-apply filters should not show a bar for null values (metabase#12138) should not show a database prompt banner when logged in as an admin, an instance is on a paid plan, and only have a single sample dataset, but is white labelled (Replay 1, Replay 2) should not show binning for a numeric custom column should not show binning options for a coordinate custom column should not show binning options for an entity key, regardless of its underlying type (metabase#17768) should not show data model visited tables in search or in "Pick up where you left off" items on homepage (metabase#21984) should not show duplicate models in the data picker after it's moved from a custom collection without refreshing (metabase#19737) should not show events for non-timeseries questions should not show pinned questions in recent items when viewed in a collection should not show pins or a helper text (metabase#20043) should not show saved questions DB in native question's DB picker (metabase#18418) should not show scrollbars for very short snippet (metabase#21550) should not show suggestions for an unfocused field (metabase#31643) should not show temporal units for a date/time custom column should not show the app bar when previously logged in should not show the root collection name in breadcrumbs if the user does not have access to it (metabase#23981) should not show toast should not show toast should not show visualization or question settings to users with block data permissions should not show you a toast after it has been dismissed should not slugify users' collections page URL should not snow you upload buttons if you are a sandboxed user should not split the y-axis on native queries with two numeric columns should not split the y-axis when columns are of the same semantic_type and have close values should not split the y-axis when semantic_type, column settings are same and values are not far should not split the y-axis when the setting is disabled should not suggest arithmetic operators should not throw an error when converting a table question to sql (metabase#21615) should not transform text variables to plain text (metabase#31626) should not treat the question as verified anymore should now allow setting foreign key mapping for inaccessible tables should now display null values (metabase#16246) should offer to duplicate a question in a view-only collection (metabase#22726) should offer to save dashboard to a currently opened collection should offer to save dashboard to a currently opened collection should offer to save dashboard to a currently opened collection should offer to save dashboard to root collection from a dashboard page (metabase#16832) should offer to save items to 'Our analytics' if user has a 'curate' access to it should only allow non-admin users to see a public link if one has already been created should only allow non-admin users to see a public link if one has already been created should only call the autocompleter with all text typed (metabase#34330) should only display cards on the selected tab should only display filters mapped to cards on the selected tab should only fetch cards on the current tab should only show currency formatting options for currency fields should only show current user in recipients dropdown if `user-visiblity` setting is `none` should only show one toast on login should only show users in same group in recipients dropdown if `user-visiblity` setting is `group` should open 'Saved Questions' database correctly should open 'Saved Questions' database correctly should open drill-through menu as a default click-behavior should open drill-through menu as a default click-behavior should open slugified URLs correctly should open the same dashboard when a custom URL click behavior points to the same dashboard (metabase#22702) should order columns correctly in saved native query exports should order columns correctly in saved native query exports should order columns correctly in saved native query exports when the query was modified but not re-run before save (#19889) should order columns correctly in saved native query exports when the query was modified but not re-run before save (#19889) should order columns correctly in unsaved native query exports should pass `redirect` search params from Google button screen to email/password screen (metabase#16216) should pass multiple filter values to questions and dashboards (metabase#17160-1) should pass parameters when running with 'Run select text' (metabase#16584) should persist attachments for dashboard subscriptions (metabase#14117) should preserve collection names for default timelines should preserve correct order of columns after column removal via sidebar (metabase#13455) should preserve draft parameter values when editing of the dashboard was cancelled should preserve embedding options with click behavior (metabase#24756) should preserve filter value when navigating between the dashboard and the query builder with auto-apply disabled (metabase#34382) should preserve filter value when navigating between the dashboard and the question without re-fetch should preserve params when navigating should preserve query results when navigating between the dashboard and the query builder should prompt admin to migrate to the hosted instance should prompt you to add email/slack credentials should properly cache parameter values api calls should properly show contents of different collections with the same name (metabase#24660) should properly work with native questions (metabsae#15808, metabase#16938, metabase#18364) should re-fetch the query when doing undo on the removal should recognize template tags and save them as parameters should recover visualization settings after a failed query (metabase#16914) should redirect from /auth/forgot_password back to /auth/login (viewport: 1280,800) (metabase#12658) should redirect from /auth/forgot_password back to /auth/login (viewport: 640,360) (metabase#12658) should redirect to / when logged in should redirect to /auth/login should redirect to an unsaved question after login should redirect you if you do not have permissions for set dashboard should refelct column settings accurately when changing (metabase#30966) should reflect to updated action on mapping form should regenerate embedding token and invalidate previous embed url (Replay 1, Replay 2) should relay the type of a date field should remove `/notebook` from URL when converting question to SQL/Native (metabase#12651) should remove a boolean filter should remove a join when changing the source table should remove an existing filter should remove only invalid join clauses (metabase#17710) should remove post-aggregation filters from a multi-stage query (metabase#13504) should render a pie chart (metabase#12506) (#35244) should render binning options when joining on the saved native question (metabase#18646) should render database prompt banner when logged in as an admin, an instance is on a paid plan, only have a single sample dataset, and is not white labeling (Replay 1, Replay 2) should render date without time (metabase#7494) should render error message when `params` is not an object (metabase#14474) should render error without crashing when embed query returns error (metabase#34954) should render grid map visualization for native questions (metabase#8362) should render human readable numbers on desktop screen size (metabase should render human readable numbers on hd screen size (metabase should render human readable numbers on tablet screen size (metabase should render long value with tooltip should render longitude/latitude binning options correctly should render longitude/latitude binning options correctly should render number binning options correctly should render number binning options correctly should render scalar with correct size on the first render (metabase#29304) should render short value without tooltip should render smart scalar with correct size on the first render (metabase#29304) should render static-viz when date formatting contains day (metabase#27105) should render static-viz when date formatting is abbreviated (metabase#27020) should render time series binning options correctly should render time series binning options correctly should render values on data points should replace a dashboard card question (metabase#36984) should reset 'another column' comparison when it becomes invalid should reset filter state when all values are unselected (metabase#25533) should reset modal state when navigating away should reset pagination if sorting applied on not first page should reset password via email should reset user password with SMTP set up should reset user password without SMTP set up should respect 'disable auto-apply filters' in a public dashboard should respect circle size in a visualization (metabase#22929) should respect default filter precedence (dashboard filter, then SQL field filters) should respect default filter precedence while properly updating the url for each step of the flow should respect email alerts toggled off (metabase#12349) should respect impersonated permission should respect permissions should respect renamed column names in the settings sidebar (metabase#18476) should respect symbol settings for all currencies should restore a dashboard with loading cards and re-fetch query data should retain the filter when drilling through the dashboard card with implicitly added column (metabase#23293) should return correct values for Auto bin should return correct values for Bin every 0.1 degrees should return correct values for Bin every 1 degree should return correct values for Bin every 10 degrees should return correct values for Bin every 20 degrees should return correct values for Day should return correct values for Day of month should return correct values for Day of week should return correct values for Day of year should return correct values for Hour should return correct values for Hour of day should return correct values for Minute should return correct values for Minute of hour should return correct values for Month should return correct values for Month of year should return correct values for Quarter should return correct values for Quarter of year should return correct values for Week should return correct values for Week of year should return correct values for Year should return the same number of rows when running as an ad-hoc query vs a saved card (metabase#34278) should return to dashboard with specific tab selected should revert a saved question to a previous version should sandbox parameter values in dashboards should sandbox parameter values in questions should save a dashboard after adding a saved question from an empty state (metabase#29450) should save and obey field prefix formatting settings should save the client id on subsequent tries (metabase#15974) should save the metric using custom expressions (metabase#13022) should say to non-admins that admin must add email credentials should search for events should see 8 tables in sample database should see a child collection in a sidebar even with revoked access to its parents (metabase#14114, metabase#16555, metabase#20716) should see a newly asked question in its questions list should see a newly asked question in its questions list should see multiple fields should see public actions should see public dashboards should see public questions should see the created_at timestamp field should see the id field should see the listing should see the listing should send a test email for a valid SMTP configuration should send as BCC by default should send as CC when opted-in should send event when clicking `Turn into a model` should send snowplow events through admin settings should send snowplow events through homepage should send snowplow events when cards are moved between tabs should send snowplow events when clicking on links in the database prompt banner (Replay 1, Replay 2) should send snowplow events when creating a timeline event should send snowplow events when dashboard tabs are created and deleted should send snowplow events when disabling auto-apply filters should set custom cache ttl should set multiple filter values via url should set up an email alert should set up an email alert for newly created question should setup ldap (metabase#16173) should shallow duplicate a dashboard but not its cards should shallow duplicate a dashboard but not its cards should shallow duplicate a dashboard but not its cards should should correctly display 'Save' modal (metabase#13817) should show 'Previous results' instead of a table name for non-field dimensions (metabase#17968) should show 404 if database does not exist (metabase#14652) should show 404 page when missing required parameters should show a database prompt banner when logged in as an admin, an instance is on a paid plan, only have a single sample dataset, and is not white labelled (Replay 1, Replay 2) should show a disabled button for card should show a disabled button for dashboard should show a disabled embed button if the card doesn't have a public link should show a disabled embed button if the dashboard doesn't have a public link should show a disabled menu item for public links for card and allow the user to access the embed modal should show a disabled menu item for public links for dashboard and allow the user to access the embed modal should show a filter description containing default values, even when not explicitly added to subscription should show a group by column from the joined field in the summarize sidebar (metabase#27873) should show a modal when a revision changes while an admin is editing (Replay 1, Replay 2) should show a modal when a revision changes while an admin is editing (Replay 1, Replay 2) should show a notification with a link to the release notes, and allow the dismissal of it should show a proper error message when using custom mapping should show all collections when selecting a dashboard for a question in a public collection should show all users in recipients dropdown if `user-visiblity` setting is `all` should show an (empty) bar for null values when X axis is ordinal (metabase#12138) should show an error if test email fails should show an error message if the client id does not end with the correct suffix (metabase#15975) should show archived items (metabase#15080, metabase#16617) should show archived items (metabase#15080, metabase#16617) should show archived items (metabase#15080, metabase#16617) should show card descriptions (metabase#18454) should show CE that uses 'AND/OR' (metabase#13069, metabase#13070) should show collection breadcrumbs for a saved question in a non-root collection should show collection breadcrumbs for a saved question in the root collection should show correct labels in tooltip (metabase#15150) should show correct labels in tooltip when display name has manually set (metabase#11395) should show dashboard subscriptions for sandboxed user (metabase#14990) should show detailed form errors for constraint violations when executing model actions should show detailed form errors for constraint violations when executing model actions should show detailed form errors for constraint violations when executing model actions should show disabled embed button and tooltip for card should show disabled embed button and tooltip for dashboard should show error and disable the form after target dashboard tab has been removed and there is more than 1 tab left should show error for multi-series questions (metabase#15152) should show error message when server responds with an error should show error upon a bad request should show errors when previewing a query should show events for ad-hoc questions should show events for native queries should show existing dashboard subscriptions should show expression function helper if a proper function is typed should show field metadata in a popover when hovering over a table column header should show field metadata popovers for native query tables should show filtered categories should show filters defined on a question with filter pass-thru (metabase#15993) should show how to create metrics should show implicit joins on FK columns with real DB columns (#37067) should show inline category picker for referral source should show label for empty value series breakout (metabase#32107) should show list of collection items even if one question has invalid parameters (metabase#25543) should show login form when directed to sign in with email should show models should show moved model in the data picker without refreshing (metabase#19737) should show mysql writable_db with actions enabled should show no metrics in the list should show no questions based on a new metric should show no questions based on a new segment should show no segments should show number of API keys on auth card should show permissions error after applying a filter to the question should show postgres writable_db with actions enabled should show question creation controls by a param should show search controls by a param should show SSO button should show sub-day resolutions in relative date filter (metabase#6660) should show table name in header with a table info popover on hover should show tables should show the button to sign in via google only when enabled should show the correct tooltip details for pin map even when some locations are null (metabase#18063) should show the dashboard header by default should show the dashboard header by default should show the database for a new native question (metabase#21511) should show the default homepage if the dashboard was archived (#31599) should show the embed button if the card has a public link should show the embed button if the dashboard has a public link should show the embed menu for card should show the embed menu for dashboard should show the field metadata popover for a foreign key field (metabase#19577) should show the login form when ldap is enabled but password login isn't (metabase#25661) should show the metric detail view for a specific id should show the question header by default should show the question lineage when a saved question is changed should show the segment details of a specific id should show the segment fields list and detail view should show the SSO button without an option to use password should show the store link when running Metabase OSS should show the top and side nav by default should show the trend line should show up in UI list should show up in user's HTML should show updated column titles in tooltips after editing them via Visualization Options should show updated column titles in tooltips after editing them via Visualization Options should show updated column titles in tooltips after editing them via Visualization Options should show updated column titles in tooltips after editing them via Visualization Options should show updated column titles in tooltips after editing them via Visualization Options should show updated column titles in tooltips after editing them via Visualization Options should show value picker for state should show verified badge in the 'Recently viewed' list (metabase#18021) should show you upload buttons if you have unrestricted access to the upload schema should slugify collection name should slugify current user's personal collection name correctly should slugify dashboard URLs should slugify database name when opening it from /browse/databases" should slugify question URLs should sort database fields by relevance should sort databases in new UI based question data selection popover should split the y-axis when column settings differ should split the y-axis when columns are of different semantic_type should split the y-six when columns are of the same semantic_type but have far values should start loading cards from top to bottom should stop the ongoing query should stop the ongoing query when removing a card from a dashboard should suggest map visualization regardless of the first column type (metabase#14254) should suggest questions saved in collections with colon in their name (metabase#14287) should suggest the currently viewed collection when saving question should suggest the currently viewed collection when saving question should support filtering by collection name should support filtering by question name should support markdown in collection description should support markdown in event description should support markdown in event description should support markdown in timeline description should support showing data points with > 10 series (#33725) should surface login errors with Google sign in enabled (metabase#16122) should sync join condition's date-time column units should toggle individual event visibility should toggle metabot visibility should track enabling the hide empty cards setting should translate parameter values into the instance language should unarchive an event from the archive and undo should understand date functions should understand string functions (metabase#13217) should undo pinning a question if turning into a model was undone should undo the question replace action should unsubscribe a user from all subscriptions and alerts should unwrap the nested query when removing all expressions (metabase#19745) should unwrap the nested query when removing the last expression (metabase#19745) should update a dashboard filter by clicking on a map pin (metabase#13597) should update an existing filter should update ldap settings should update loading message should update that metric should update that segment should update the name and description in the dashboard edit mode should update the name and description without entering the dashboard edit mode should use custom date formatting settings should use custom time formatting settings should use the correct query endpoints (metabase#20637) should validate approved email domains for a dashboard subscription (metabase#17977) should validate approved email domains for a dashboard subscription in the audit app should validate approved email domains for a question alert should work despite it not showing up in the widget type list should work for all field types (metabase#15170) should work for all filters should work for BigQuery should work for Google Analytics should work for longitude should work for longitude should work for longitude should work for longitude should work for longitude should work for longitude should work for longitude should work for longitude/latitude should work for longitude/latitude should work for longitude/latitude should work for notebook mode should work for number should work for number should work for number should work for number should work for number should work for number should work for number should work for number should work for number should work for number should work for number should work for simple mode should work for time series should work for time series should work for time series should work for time series should work for time series should work for time series should work for time series should work for time series should work for time series should work for time series should work for time series should work for timeseries questions with a set goal should work for unaggregated data (metabase#15465) should work on questions with explicit joins (metabase#13112) should work properly when connected to the explicitly joined field should work regardless of column order (metabase#13710) should work when set as the default filter should work when set as the default filter should work when set as the default filter should work when set as the default filter should work when set as the default filter should work when set as the default filter should work when set as the default filter and when that filter is removed (metabase#20493) should work when set as the default filter which (if cleared) should not be preserved on reload (metabase#13960) should work when set initially as default value and then through the filter widget should work when set through the filter widget should work when set through the filter widget should work when set through the filter widget should work when set through the filter widget should work when set through the filter widget should work when set through the filter widget should work when set through the filter widget should work when set through the filter widget should work when using dashboard default filter value on native query with required parameter (metabase#15705) should work with 'after/before' date filter (metabase#15352-2) should work with 'between' date filter (metabase#15352-1) should work with 'on' date filter (metabase#15352-3) should work with boolean columns should work with implicit joins (metabase#14080) should work with ordinal series should work with ordinal series and numeric X-axis (metabase#15550) should work with pivot tables (metabase#14969) should work with quantitative series should work with relative date filter applied to a custom column (metabase#16273) should work with time columns should work with time-series data shouldn't allow to turn native questions with variables into models shouldn't allow using variables in native models shouldn't be able to archive/edit root or personal collection shouldn't be able to archive/edit root or personal collection shouldn't be able to archive/edit root or personal collection shouldn't be possible to save a non-numeric port (#13313) shouldn't create a rearrange revision when adding a card (metabase#6884) shouldn't create a rearrange revision when adding a card (metabase#6884) shouldn't create a rearrange revision when adding a card (metabase#6884) shouldn't drop joins using MLv2 format (metabase#31769) shouldn't drop native model query results after leaving the query editor shouldn't duplicate the breakout field (metabase#22382) shouldn't remove parts of the query when choosing "Run selected text" (metabase#16886) shouldn't remove rows containing NULL when using "Is not" or "Does not contain" filter (metabase#13332, metabase#37100) shouldn't render double binning options when question is based on the saved native question (metabase#16327) shouldn't render revision history steps when there was no diff (metabase#1926) shouldn't reorder template tags when updated (metabase#11580) shouldn't update root permissions when changing permissions on a created folder (metabase#17268) show selected option for the collection with children (Replay 1, Replay 2) shows `Field access denied` for foreign keys from tables user does not have access to (metabase#21762) shows 404 when opening a question with a /dataset URL shows alerts shows correct page when visiting page of question that was in archived collection (metabase##23501) shows filterable list of groups (Replay 1, Replay 2) shows hidden tables (Replay 1, Replay 2) shows list of recently viewed items shows permission error for cards that use blocked data sources shows permissions help shows permissions help shows sorted cards on mobile screens shows subscriptions shows up-to-date list of recently viewed items after another page is visited (metabase#36868) simple sandboxing should work (metabase#14629) sub-collection should be available in save and move modals (metabase#14122) suggest the currently viewed collection when saving a new native query suggest the currently viewed collection when saving a new structured query summarize with null values (metabase#12585) summarizing by distinct datetime should allow granular selection (metabase#13098) supports up to 100 series (metabase#28796) third level of nesting with joins should result in proper column aliasing (metabase#22859-2) transforms the data picker typing a card tag should open the data reference unsaved/dirty query should work on linked table column with multiple dimensions and remapping (metabase#15106) updates databases list in Database Browser after bringing sample database back user session should not apply sandboxing to a signed embedded question (metabase#30535) view and filter saved question visiting already archived collection by its ID shouldn't let you edit it (metabase#12489) visiting already archived collection by its ID shouldn't let you edit it (metabase#12489) visiting already archived collection by its ID shouldn't let you edit it (metabase#12489) Visualization and Settings query builder buttons are not visible for questions that use blocked data sources warns about leaving with unsaved changes (Replay 1, Replay 2) warns about leaving with unsaved changes (Replay 1, Replay 2) warns when All Users have impersonated access and the target group has no self-service access when clicking on the card title (metabase#13062-2) when clicking on the field value (metabase#13062-1) when set as the default filter when set as the default filter when set as the default filter when set as the default filter when set as the default filter when set as the default value for a required filter when set as the default value for a required filter when set as the default value for a required filter when set as the default value for a required filter when set as the default value for a required filter when set as the default value for a required filter (metabase#16811) when set through the filter widget when set through the filter widget when set through the filter widget when set through the filter widget when set through the filter widget when set through the filter widget when set through the filter widget when set through the filter widget when set through the filter widget when set through the filter widget when set through the filter widget when there's a default value and input is empty, blur sets default value back when there's a default value and input is empty, blur sets default value back when there's a default value and template tag is required, can reset it back when there's a default value and template tag is required, can reset it back when there's a default value and template tag is required, can reset it back when there's a default value and template tag is required, can reset it back when there's a default value and value is unset, updating filter sets the default back when there's a default value, enabling required sets it as a parameter value when there's a default value, enabling required sets it as a parameter value when there's a default value, enabling required sets it as a parameter value when there's a default value, enabling required sets it as a parameter value when undoing a dashcard removal or dashcard tab movement, it should try to restore the position (best effort) withSqlite (Replay 1, Replay 2, Replay 3, Replay 4, Replay 5, Replay 6, Replay 7, Replay 8, Replay 9, Replay 10, Replay 11, Replay 12, Replay 13, Replay 14, Replay 15, Replay 16, Replay 17, Replay 18, Replay 19, Replay 20, Replay 21, Replay 22, Replay 23, Replay 24, Replay 25, Replay 26) works when both filters are enabled and their values are set through UI works when both filters are enabled and their values are set through UI works when both filters are enabled and their values are set through UI with auto-apply filters disabled works when main filter is locked works when main filter's value is set through URL works when main filter's value is set through URL works when main filter's value is set through URL and when it is hidden at the same time works when the default filter is hidden works when the default filter is locked x-rays should work on explicit joins when metric is for the joined table (metabase#14793)

:width key is now needed in some revision tests. As well we need a string communicating that the :width setting has changed from 'full' to 'fixed' or vice-versa.

resources/migrations/001_update_migrations.yaml

markbastian

Update the comment and remarks in the last migration and then it will be g2g.

markbastian

Looks good.

…metabase/metabase into fixed-width-dashboard-migration

Signed-off-by: Adam James <adam.vermeer2@gmail.com>

github-actions · 2024-02-01T19:38:11Z

@adam-james-v Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

* Migration adding 'width' to Dashboards 3 migrations: - 1st adding the width column with default value of 'fixed' - 2nd updating all existing dashboards to have width 'full', which corresponds to what the current behaviour is (will be the 'old' behaviour after the fixed-width project lands). - The rolloback here is necessary but we don't care what happens as the column will be dropped immediately in the next rollback anyway - 3rd sets the notNullableConstraint. DefaultNull is 'full' here, just in case there's an existing dashboard whose width value is not yet set from the 1st migration. Don't know how that could happen, but its here in case * Dashboard PUT api endpoint accepts width changes and updates appdb update-dashboard function now is aware of the :width key so those changes can end up in the transaction. Also added a width test that asserts that the value's default is "fixed", it can be changed, eg. to "full", but cannot be changed to other values. * Add width to revision tests * Fix dashboard revision tests. :width key is now needed in some revision tests. As well we need a string communicating that the :width setting has changed from 'full' to 'fixed' or vice-versa. * Fix comments/remarks in migration to be accurate * Attempt to fix default not working mysql/mariadb * Set default in dashboard model Signed-off-by: Adam James <adam.vermeer2@gmail.com> * Revert default :width 'fixed' value. * Explicitly add default value 'fixed' for MySQL/MariaDB --------- Signed-off-by: Adam James <adam.vermeer2@gmail.com>

adam-james-v requested a review from camsaul as a code owner January 30, 2024 00:12

adam-james-v requested review from markbastian and removed request for camsaul January 30, 2024 00:12

adam-james-v self-assigned this Jan 30, 2024

adam-james-v added the .Team/DashViz Dashboard and Viz team label Jan 30, 2024

adam-james-v requested a review from JesseSDevaney January 30, 2024 00:16

adam-james-v added 2 commits January 29, 2024 16:44

adam-james-v force-pushed the fixed-width-dashboard-migration branch from ab31924 to 78960bf Compare January 30, 2024 00:45

adam-james-v added the no-backport Do not backport this PR to any branch label Jan 30, 2024

Add width to revision tests

d0f2311

JesseSDevaney mentioned this pull request Jan 30, 2024

Default dashboards to a fixed width to give creators a more predictable canvas #36358

Closed

11 tasks

Fix dashboard revision tests.

febd5f4

:width key is now needed in some revision tests. As well we need a string communicating that the :width setting has changed from 'full' to 'fixed' or vice-versa.

markbastian reviewed Jan 30, 2024

View reviewed changes

resources/migrations/001_update_migrations.yaml Outdated Show resolved Hide resolved

markbastian suggested changes Jan 30, 2024

View reviewed changes

Fix comments/remarks in migration to be accurate

f82b98d

markbastian approved these changes Jan 30, 2024

View reviewed changes

Merge branch 'master' into fixed-width-dashboard-migration

19f01a9

JesseSDevaney approved these changes Jan 31, 2024

View reviewed changes

adam-james-v added 5 commits February 1, 2024 08:58

Attempt to fix default not working mysql/mariadb

b8690be

Merge branch 'fixed-width-dashboard-migration' of https://github.com/…

6abeb0a

…metabase/metabase into fixed-width-dashboard-migration

Set default in dashboard model

e38be38

Signed-off-by: Adam James <adam.vermeer2@gmail.com>

Revert default :width 'fixed' value.

c634c0b

Explicitly add default value 'fixed' for MySQL/MariaDB

e967120

adam-james-v merged commit ffd1873 into master Feb 1, 2024
105 checks passed

adam-james-v deleted the fixed-width-dashboard-migration branch February 1, 2024 19:37

noahmoss mentioned this pull request Feb 19, 2024

Unknown error in the revision history of a dashboard leads to a NullPointerException #38910

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed width dashboard migration #38247

Fixed width dashboard migration #38247

adam-james-v commented Jan 30, 2024 •

edited by JesseSDevaney

replay-io bot commented Jan 30, 2024 •

edited

markbastian left a comment

markbastian left a comment

github-actions bot commented Feb 1, 2024

Fixed width dashboard migration #38247

Fixed width dashboard migration #38247

Conversation

adam-james-v commented Jan 30, 2024 • edited by JesseSDevaney

replay-io bot commented Jan 30, 2024 • edited

markbastian left a comment

Choose a reason for hiding this comment

markbastian left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 1, 2024

adam-james-v commented Jan 30, 2024 •

edited by JesseSDevaney

replay-io bot commented Jan 30, 2024 •

edited