fix reversed stacking order #38495
Merged
fix reversed stacking order #38495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2024
Merged
Merged
|
🚨 Visual Regression Tests failed. Get the report artifact |
EmmadUsmani
force-pushed
the
02-06-fix_reversed_stacking_order
branch
from
6b50511
to
4498ebe
Compare
|
🚨 Visual Regression Tests failed. Get the report artifact |
|
Snapshots have been updated |
EmmadUsmani
force-pushed
the
02-06-fix_reversed_stacking_order
branch
from
ae6df23
to
c856657
Compare
|
🚨 Visual Regression Tests failed. Get the report artifact |
EmmadUsmani
force-pushed
the
02-06-fix_reversed_stacking_order
branch
from
c856657
to
57581c4
Compare
This was referenced Feb 8, 2024
Merged
1 task
alxnddr
pushed a commit
that referenced
this pull request
Mar 31, 2024
* fix reversed stacking order * only reverse series if it is stacked * manually update loki images
alxnddr
pushed a commit
that referenced
this pull request
Apr 15, 2024
* fix reversed stacking order * only reverse series if it is stacked * manually update loki images
alxnddr
pushed a commit
that referenced
this pull request
Apr 18, 2024
* fix reversed stacking order * only reverse series if it is stacked * manually update loki images
alxnddr
pushed a commit
that referenced
this pull request
Apr 19, 2024
* fix reversed stacking order * only reverse series if it is stacked * manually update loki images
alxnddr
pushed a commit
that referenced
this pull request
Apr 25, 2024
* fix reversed stacking order * only reverse series if it is stacked * manually update loki images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37931
Description
Fixes the stacking order of stacked bars/area charts to be top to bottom, so that they match the legend and sidebar order.
Note that the existing dc.js behavior was incorrect (legend and chart didn't match the sidebar), so this PR fixes it completely rather than recreating the incorrect behavior.
Demo
Checklist