Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include table items with the targets of FK fields #38528

Merged
merged 59 commits into from
Feb 13, 2024
Merged

Include table items with the targets of FK fields #38528

merged 59 commits into from
Feb 13, 2024

Conversation

metamben
Copy link
Contributor

@metamben metamben commented Feb 7, 2024

No description provided.

kamilmielnik and others added 30 commits January 30, 2024 21:24
@kamilmielnik
Add new empty Question.prototype.dependentMetadata
9ac57fc 
- rename old Question.prototype.dependentMetadata to Question.prototype._dependentMetadata
@kamilmielnik
Update Question.prototype.dependentMetadata return type
c4c4992
@kamilmielnik
Merge branch 'master' into 37390-dependent-metadata
585f911
@kamilmielnik
Fix dependentMetadata test
88478cd
@kamilmielnik
Implement new Question.prototype.dependentMetadata
3de1c07
@kamilmielnik
Remove old dependentMetadata implementations
530e20a
@kamilmielnik
Refactor loadMetadataForQueries to loadMetadataForQuestions, and load…
14183fe 
…MetadataForQuery to loadMetadataForQuestion

- remove extraDependencies argument
@kamilmielnik
Always fetch foreign tables
4057e96
@kamilmielnik
Remove unused attribute
59f67fd
@kamilmielnik
Rename query to question, remove redundant "else" blocks
7496e35
@kamilmielnik
Remove unused types
8b51a0d
@kamilmielnik
Bring back non-query-related dependencies
f96b2ff
@kamilmielnik
Rename query to question
ef05fea
@kamilmielnik
Remove unsupported mock data
53ffdc7
@kamilmielnik
Use Tables.actions.fetchMetadata instead of Tables.actions.fetchMetad…
9f246b9 
…ataAndForeignTables since MLv2's dependentMetadata() should provide us with all foreign tables already
@kamilmielnik
Update unit test
3830f6a
@kamilmielnik
Handle "database" dependencies in loadMetadataForQuestions
7c7036e
@kamilmielnik
Bring back Question.prototype.dependentMetadata unit tests and update…
3263ee5 
… them
@kamilmielnik
Use Databases.actions.fetch instead of Databases.actions.fetchDatabas…
33529cc 
…eMetadata
@kamilmielnik
Revert changes to reduce diff
9b66c38
@kamilmielnik
Use native Array.prototype.flatMap
1259485
@kamilmielnik
Get rid of _.chain
124c676
@kamilmielnik
Update error message
6cf70f9
@kamilmielnik
Use Array.prototype.flatMap to avoid Array.prototype.filter
1c69cda
@kamilmielnik
Do not use Lib.dependentMetadata in Question.prototype.dependentMetadata
e5edfe3 
- refactor loadMetadataForQuestions into loadMetadataForDependentItems
- remove loadMetadataForQuestion
@kamilmielnik
Fix dependentItems computation
e663644
@kamilmielnik
Rename dependencies to uniqueDependentItems
1558b90
@kamilmielnik
Update unit test
9f2e387
@metamben
Return card__<id> for non-model cards and FK targets for tables
5a0fb4a 
Fixes #38312.
@kamilmielnik
Merge branch '38312-dependent-metadata-fk-and-card__id' into 37390-de…
a0250e8 
…pendent-metadata
@metamben metamben marked this pull request as ready for review February 12, 2024 15:21
@replay-io replay.io
Copy link

replay-io bot commented Feb 12, 2024 •
edited

Status Complete ↗︎
Commit 48f0dc9
Results
⚠️ 10 Flaky
✅ 2300 Passed

@ranquild ranquild changed the base branch from 37390-dependent-metadata to master February 13, 2024 10:52
@ranquild ranquild added the no-backport Do not backport this PR to any branch label Feb 13, 2024
@ranquild ranquild merged commit ffd43d9 into master Feb 13, 2024
106 checks passed
@ranquild ranquild deleted the 37390-dependent-metadata-38510 branch February 13, 2024 19:40
@ranquild ranquild mentioned this pull request Feb 13, 2024
Closed
@kamilmielnik kamilmielnik mentioned this pull request Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoe snoe snoe approved these changes

@bshepherdson bshepherdson bshepherdson approved these changes

@ranquild ranquild ranquild approved these changes

@camsaul camsaul Awaiting requested review from camsaul camsaul is a code owner

@kamilmielnik kamilmielnik Awaiting requested review from kamilmielnik

Assignees

@metamben metamben

Labels
no-backport Do not backport this PR to any branch .Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@metamben @snoe @bshepherdson @ranquild @kamilmielnik