Partially revert 'Remove N+1 in sync' #38549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisptrutski
added
the
backport
calherries
reviewed
Feb 8, 2024
| @@ -15,8 +15,7 @@ | |||
| [database :- (mi/InstanceOf :model/Database)] | |||
| (let [driver (driver.u/database->driver database)] | |||
| (when (and (not= :redshift driver) | |||
There was a problem hiding this comment.
You can remove the redshift exclusion now and the comment below, so this is just
(when (driver/database-supports? driver :table-privileges database) ...)There was a problem hiding this comment.
I intentionally updated the comment and left this so we didn't unintentionally enable it if we roll the other changes forward again.
calherries
reviewed
Feb 8, 2024
|
Are we sure we want to revert this for PG and redshift too? see my comment |
|
Co-authored-by: Cal Herries <39073188+calherries@users.noreply.github.com>
|
We have decided against this approach, as it would revert much needed Redshift sync optimization, and we are not aware of any defects in its table-privileges implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refences:
Description
This PR reverts some components of #37439
metabase.driver.sql-jdbc.sync.interface/active-tableswhich added a new argument. We will need to maintain backwards compatibility for 3 releases, so will need to introduce a new multi-method instead.:table-privilegesfor Redshift for now, but leave the queries.