[MLv2] Prescribe the order for metabase.lib.column-group/group-columns
#38587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
|
crisptrutski
approved these changes
Feb 9, 2024
Comment on lines
+446
to
+449
| {::lib.column-group/group-type :group-type/join.implicit | ||
| :fk-join-alias "Orders" | ||
| :fk-field-id (meta/id :orders :product-id)} |
There was a problem hiding this comment.
You missed this entry in the comment above
There was a problem hiding this comment.
Ah, it was included in one line, but that was left over from when the comment was phrased differently and grouped the joins rather than listing each one.
Fixed.
bshepherdson
force-pushed
the
mblib-column-group-ordering
branch
2 times, most recently
from
ede1e69
to
a480435
Compare
bshepherdson
added
backport
|
Adding |
bshepherdson
force-pushed
the
mblib-column-group-ordering
branch
3 times, most recently
from
3fe32ac
to
ee08be3
Compare
The desired order is: own columns, explicitly joined, implicitly joined. Explicit joins are ordered among themselves by join alias. Implicit joins are ordered by the join alias of the FK (own columns first), then by the name of the FK column. Previously this order has usually been at least close to the desired order by accident, since it's close to the iteration order of `visible-columns`. However, `group-columns` uses `group-by`, which returns a map. If there are enough groups (more than 8 I think) the map implementation will switch from a `[key1 value1 key2 value2 ...]` array to a real map, and the iteration order is undefined. This change enforces the desired order, including a test that `shuffle`s the columns. (And fixing the expectations for a few other tests.)
bshepherdson
force-pushed
the
mblib-column-group-ordering
branch
from
ee08be3
to
7690738
Compare
|
@bshepherdson Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
…ns` (#38587) The desired order is: own columns, explicitly joined, implicitly joined. Explicit joins are ordered among themselves by join alias. Implicit joins are ordered by the join alias of the FK (own columns first), then by the name of the FK column. Previously this order has usually been at least close to the desired order by accident, since it's close to the iteration order of `visible-columns`. However, `group-columns` uses `group-by`, which returns a map. If there are enough groups (more than 8 I think) the map implementation will switch from a `[key1 value1 key2 value2 ...]` array to a real map, and the iteration order is undefined. This change enforces the desired order, including a test that `shuffle`s the columns. (And fixing the expectations for a few other tests.)
metabase-bot bot
added a commit
that referenced
this pull request
Feb 21, 2024
…ns` (#38587) (#39036) The desired order is: own columns, explicitly joined, implicitly joined. Explicit joins are ordered among themselves by join alias. Implicit joins are ordered by the join alias of the FK (own columns first), then by the name of the FK column. Previously this order has usually been at least close to the desired order by accident, since it's close to the iteration order of `visible-columns`. However, `group-columns` uses `group-by`, which returns a map. If there are enough groups (more than 8 I think) the map implementation will switch from a `[key1 value1 key2 value2 ...]` array to a real map, and the iteration order is undefined. This change enforces the desired order, including a test that `shuffle`s the columns. (And fixing the expectations for a few other tests.) Co-authored-by: Braden Shepherdson <braden@metabase.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The desired order is: own columns, explicitly joined, implicitly joined.
Explicit joins are ordered among themselves by join alias. Implicit
joins are ordered by the join alias of the FK (own columns first), then
by the name of the FK column.
Previously this order has usually been at least close to the desired
order by accident, since it's close to the iteration order of
visible-columns. However,group-columnsusesgroup-by, whichreturns a map. If there are enough groups (more than 8 I think) the map
implementation will switch from a
[key1 value1 key2 value2 ...]arrayto a real map, and the iteration order is undefined.
This change enforces the desired order, including a test that
shufflesthe columns. (And fixing the expectations for a few other tests.)
Fixes #38329.