Default enable-public-sharing to false for existing instances, and true for new ones #38609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
noahmoss
force-pushed
the
02-09-Default_enable-public-sharing_to_false_for_existing_instances_and_true_for_new_ones
branch
from
491a7b8
to
78d671d
Compare
|
noahmoss
force-pushed
the
02-09-Default_enable-public-sharing_to_false_for_existing_instances_and_true_for_new_ones
branch
from
78d671d
to
e3a54a4
Compare
noahmoss
force-pushed
the
02-09-Default_enable-public-sharing_to_false_for_existing_instances_and_true_for_new_ones
branch
from
e3c80f3
to
7d8e7ef
Compare
npretto
approved these changes
Feb 9, 2024
perivamsi
deleted the
02-09-Default_enable-public-sharing_to_false_for_existing_instances_and_true_for_new_ones
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per description here: https://metaboat.slack.com/archives/CKZEMT1MJ/p1707486868091979?thread_ts=1707476058.522989&cid=CKZEMT1MJ
enable-public-sharingshould default totrue, but existing instances should see it remainfalseif not otherwise set