🤖 backported "Fix custom destination to public dashboard not working on static embedding" #38652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![metabase-bot[bot]](https://avatars.githubusercontent.com/in/220029?s=60&v=4){kind=small}
…dding (#38647) * Fix linking to public or embed resource on dashboards not working * Update embedding test name to use a snazzier term * Add tests
metabase-bot
bot
added
the
was-backported
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
WiNloSt
reviewed
Feb 12, 2024
| @@ -122,3 +122,8 @@ export function createPublicQuestionLink(questionId) { | |||
| export function createPublicDashboardLink(dashboardId) { | |||
| return cy.request("POST", `/api/dashboard/${dashboardId}/public_link`, {}); | |||
| } | |||
|
|
|||
| export function openStaticEmbeddingModal() { | |||
There was a problem hiding this comment.
This util only exists on 49. So I introduced the same name util but cater 48 UI
metabase-bot
bot
deleted the
backport-38640-fix-public-or-embed-navigation-to-not-use-client-side-routing-release-x.48.x
branch
qwef
pushed a commit
that referenced
this pull request
Feb 12, 2024
…on static embedding" (#38652) * Fix custom destination to public dashboard not working on static embedding (#38647) * Fix linking to public or embed resource on dashboards not working * Update embedding test name to use a snazzier term * Add tests * Add missing test util from 49 --------- Co-authored-by: Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> Co-authored-by: Mahatthana Nomsawadi <mahatthana.n@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#38647