Fix isNavigationAllowed #38703
Merged
Fix isNavigationAllowed #38703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilmielnik
commented
Feb 13, 2024
| @@ -208,7 +208,6 @@ export const getRoutes = store => { | |||
| title={t`New Model`} | |||
| component={NewModelOptions} | |||
| /> | |||
| <Route path="notebook" component={QueryBuilder} /> | |||
There was a problem hiding this comment.
/model/notebook route is never used.
However /model/:id/notebook is.
kamilmielnik
commented
Feb 13, 2024
| @@ -243,14 +244,6 @@ describe("isNavigationAllowed", () => { | |||
| ).toBe(true); | |||
| }); | |||
|
|
|||
| it("allows to run a model", () => { | |||
There was a problem hiding this comment.
This test was invalid (copy-paste remnants) - it's for a model, but the describe is for a question
kamilmielnik
commented
Feb 13, 2024
| `/model/${slug}`, | ||
| `/model/${slug}/query`, | ||
| `/model/${slug}/metadata`, | ||
| `/model/${slug}/notebook`, |
There was a problem hiding this comment.
Added this route
kamilmielnik
commented
Feb 13, 2024
| ).toBe(true); | ||
| }); | ||
|
|
||
| it("allows to run the model and then edit it again", () => { |
There was a problem hiding this comment.
This test was invalid (non-existing route).
kamilmielnik
commented
Feb 13, 2024
| ).toBe(true); | ||
| }); | ||
|
|
||
| it("allows to run the model and then edit it again", () => { |
There was a problem hiding this comment.
This test was invalid (non-existing route).
kamilmielnik
commented
Feb 13, 2024
| hash: `#${serializeCardForUrl(nativeModelCard)}`, | ||
| }); | ||
|
|
||
| const runModelEditNotebookLocation = createMockLocation({ |
There was a problem hiding this comment.
Non-existing route.
kamilmielnik
commented
Feb 13, 2024
| const runModelEditNotebookLocation = createMockLocation({ | ||
| pathname: "/model/notebook", | ||
| const runNewModelLocation = createMockLocation({ | ||
| pathname: "/model/query", |
There was a problem hiding this comment.
Updated pathname to correct one
|
uladzimirdev
approved these changes
Feb 13, 2024
|
@kamilmielnik Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
|
@metabase-bot backport release-x.49.x |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
* Removed unused route * Remove invalid test * Remove invalid routes from isNavigationAllowed, update tests * Remove invalid route * Handle /model/:id/notebook route * Migrate Question.prototype.isDataset to Question.prototype.type * Consolidate code * Add missing attribute * Type cards and questions for extra safety * Fix running edited models * Improve diff
metabase-bot bot
added a commit
that referenced
this pull request
Feb 13, 2024
* Removed unused route * Remove invalid test * Remove invalid routes from isNavigationAllowed, update tests * Remove invalid route * Handle /model/:id/notebook route * Migrate Question.prototype.isDataset to Question.prototype.type * Consolidate code * Add missing attribute * Type cards and questions for extra safety * Fix running edited models * Improve diff Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for #37357
Description
I got confused when working on #37357 as some of the existing things didn't make any sense. Blame me.
Luckily, nothing was really broken. More details below and in PR comments.
/model/notebookrouteQuestion.prototype.typeinsteadQuestion.prototype.isDataset/model/:id/notebookis not preventedgetShouldShowUnsavedChangesWarning