Add Creator Sentiment Email task #38787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwef
changed the title
|
noahmoss
approved these changes
Feb 19, 2024
|
|
||
| (defn- fetch-num-dashboards [] | ||
| (-> | ||
| (t2/query-one {:select [[:%count.* :num_dashboards]] |
There was a problem hiding this comment.
can you use t2/count for these simpler count queries?
Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
|
@qwef Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
dpsutton
added
backport
github-actions bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
* Add new email function and send email to creator * remove debug stuff * add tests, address comments * actually add tests * Update src/metabase/email/messages.clj Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com> * address comments --------- Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
metabase-bot bot
added a commit
that referenced
this pull request
Mar 4, 2024
* Add new email function and send email to creator * remove debug stuff * add tests, address comments * actually add tests * Update src/metabase/email/messages.clj * address comments --------- Co-authored-by: Jerry Huang <34140255+qwef@users.noreply.github.com> Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38739
Demo