-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appends follow-up UI fixes #38837
Appends follow-up UI fixes #38837
Conversation
Codenotify: Notifying subscribers in CODENOTIFY files for diff 08b8dfb...e9f1400.
|
|
IMO, if there are any to append to, we should just auto-select one of them, since even dumbly selecting the first one alphabetically has a higher probability of being the one the user intended (>0% chance of being right) than the probability that no selection is the correct one (exactly 0%, haha). If it's easy to be slightly smarter (like auto selecting the one with the most recent last_edited_at date or something), so much the better. |
ok, now this will auto-select the most recently update model (which will also be the only model if there's just one) |
useEffect( | ||
function setDefaultTableId() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I named this function especially for @sloansparger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
65ed0f3
to
e9f1400
Compare
Description
A couple little things came up during today's demo:
we should auto-select the only model to append if there's only 1
there was a bug where if you did certain things in the ui (like create a new question), we would re-trigger an error modal.
Tests