Filter picker search free input #38907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranquild
added
no-backport
|
ranquild
commented
Feb 19, 2024
| }); | ||
|
|
||
| userEvent.type(screen.getByPlaceholderText("Search by Email"), "a@b.com"); | ||
| userEvent.hover(screen.getByText("New a@b.com")); |
There was a problem hiding this comment.
For some reason mantine doesn't work without hovering the item first :(
There was a problem hiding this comment.
It'd be helpful if this comment lived in the code
kamilmielnik
approved these changes
Feb 20, 2024
|
|
||
| userEvent.type(screen.getByLabelText("Filter value"), "a@b.com"); | ||
| expect(screen.queryByText("New a@b.com")).not.toBeInTheDocument(); | ||
| expect(onChange).not.toHaveBeenCalled(); |
There was a problem hiding this comment.
Let's try to hit Enter before the assertions
| }); | ||
|
|
||
| userEvent.type(screen.getByPlaceholderText("Search by Email"), "a@b.com"); | ||
| userEvent.hover(screen.getByText("New a@b.com")); |
There was a problem hiding this comment.
It'd be helpful if this comment lived in the code
| @@ -63,12 +67,15 @@ export function SearchValuePicker({ | |||
| value={selectedValues} | |||
| searchValue={searchValue} | |||
| placeholder={placeholder} | |||
| nothingFound={isSearched ? nothingFound : null} | |||
| shouldCreate={shouldCreate} | |||
| getCreateLabel={searchValue => t`New ${searchValue}`} | |||
There was a problem hiding this comment.
- Ideally the "new" value should not be displayed when an exact match is found:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product doc https://www.notion.so/metabase/Free-up-text-input-performance-from-loading-values-in-filters-f70287f73d014794abb60653c6d28e39
Fixes #37906
Previously it wasn't possible to select a value not from the list for "searchable" columns. It becomes a problem when it takes a lot of time to load search results as they are loaded from the customer DB directly. In this case the user is not able to create a filter at all.
Now we allow entering any value, even without waiting for search results (but no duplicates). This is based on
creatableproperty of the mantine'sMultiSelect. I've decided to go withNew {input}label but this is to be verified with Product.How to verify:
Before
With search results:
No search results:
After
With search results:
No search results:
