🤖 backported "Fixes filters against datetime binned expressions" #38975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![metabase-bot[bot]](https://avatars.githubusercontent.com/in/220029?s=60&v=4){kind=small}
* Fixes filters against datetime binned expressions Fixes #33528 Turns out that `mbql/normalize` and `lib/normalize` behaved slightly different and `[:expression "abc" {...}]` refs would drop their opts in the former path. In order to properly query against binned datetimes it's important that expression ref does not lose its type or else the optimizer will not see that `time-interval` needs to convert to a `between` rather than an `=`. * Fix test * Only keep specific keys on expression opts for these expression filters * Don't run checkin dataset on snowflake or athena
metabase-bot
bot
added
the
was-backported
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
metabase-bot
bot
deleted the
backport-7f9afb07bca591c5c77502490a52c0bc181df83d
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#38874