Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix previews for multi-stage queries #39108

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Fix previews for multi-stage queries #39108

merged 3 commits into from
Feb 23, 2024

Conversation

ranquild
Copy link
Contributor

Fixes #39102

Previously we didn't drop stages correctly when constructing a preview query for a multi-stage query for intermediate stages.

How to verify:

  • CI green
  • The new E2E test follows the steps from the issue

@ranquild ranquild self-assigned this Feb 23, 2024
@ranquild ranquild added the backport Automatically create PR on current release branch on merge label Feb 23, 2024
@ranquild ranquild requested a review from a team February 23, 2024 14:20
@replay-io replay.io
Copy link

replay-io bot commented Feb 23, 2024 •
edited

Status Complete ↗︎
Commit 10665b9
Results
⚠️ 1 Flaky
✅ 2322 Passed

nemanjaglumac
nemanjaglumac approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@nemanjaglumac nemanjaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it locally. Works like a charm!

@ranquild ranquild enabled auto-merge (squash) February 23, 2024 14:51
@ranquild ranquild merged commit 12e062e into master Feb 23, 2024
117 of 137 checks passed
@ranquild ranquild deleted the preview-query-multi-stage branch February 23, 2024 14:54
github-actions bot pushed a commit that referenced this pull request Feb 23, 2024
@ranquild
Fix previews for multi-stage queries (#39108)
e7459f6
@metabase-bot metabase-bot bot mentioned this pull request Feb 23, 2024
Merged
metabase-bot bot added a commit that referenced this pull request Feb 23, 2024
@metabase-bot @ranquild
Fix previews for multi-stage queries (#39108) (#39113)
2141db3 
Co-authored-by: Alexander Polyankin <alexander.polyankin@metabase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemanjaglumac nemanjaglumac nemanjaglumac approved these changes

@uladzimirdev uladzimirdev uladzimirdev approved these changes

Assignees

@ranquild ranquild

Labels
backport Automatically create PR on current release branch on merge .Team/QueryingComponents
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preview results of intermediate stages are wrong in query builder
3 participants
@ranquild @nemanjaglumac @uladzimirdev