[MLv2] Ensure :name is unique on returned columns in the FE
#39118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is FE-only because this is a compatibility issue with the (legacy) metadata coming back from the QP. In time, the FE logic should be ported to MLv2 or made to depend on things other than the `:name` field. MLv2 code itself (including BE usage) should be based on the (already unique) `:lib/desired-column-alias`. Fixes #37517.
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
bshepherdson
added
the
backport
|
bshepherdson
added a commit
that referenced
this pull request
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is FE-only because this is a compatibility issue with the (legacy)
metadata coming back from the QP.
In time, the FE logic should be ported to MLv2 or made to depend on
things other than the
:namefield. MLv2 code itself (including BEusage) should be based on the (already unique)
:lib/desired-column-alias.Fixes #37517.