Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env var to hide built-in geojson #39132

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

noahmoss
Copy link
Member

@noahmoss noahmoss commented Feb 23, 2024

Adds an environment variable to hide the built-in geojson maps, per product request. Closes #39079

Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label Feb 23, 2024
@noahmoss noahmoss marked this pull request as ready for review February 23, 2024 20:04
@noahmoss noahmoss requested a review from a team February 23, 2024 20:04
@noahmoss noahmoss added the backport Automatically create PR on current release branch on merge label Feb 23, 2024
Copy link

replay-io bot commented Feb 23, 2024

Status Complete ↗︎
Commit 1ef5ce0
Results
⚠️ 3 Flaky
2320 Passed

Copy link
Contributor

@escherize escherize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahmoss noahmoss enabled auto-merge (squash) February 23, 2024 20:36
@noahmoss noahmoss merged commit f557d29 into master Feb 23, 2024
107 checks passed
@noahmoss noahmoss deleted the 02-23-Add_env_var_to_hide_built-in_geojson branch February 23, 2024 20:55
Copy link

@noahmoss Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

github-actions bot pushed a commit that referenced this pull request Feb 23, 2024
metabase-bot bot added a commit that referenced this pull request Feb 23, 2024
Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide the default maps
2 participants