-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix incorrect tooltip value in pie chart #39180
Merged
EmmadUsmani
merged 1 commit into
master
from
02-26-fix_incorrect_tooltip_value_in_pie_chart
Feb 27, 2024
Merged
fix incorrect tooltip value in pie chart #39180
EmmadUsmani
merged 1 commit into
master
from
02-26-fix_incorrect_tooltip_value_in_pie_chart
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
Codenotify: Notifying subscribers in CODENOTIFY files for diff d092c30...897eccd.
|
|
alxnddr
approved these changes
Feb 26, 2024
@EmmadUsmani Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
EmmadUsmani
added a commit
that referenced
this pull request
Feb 27, 2024
oisincoveney
pushed a commit
that referenced
this pull request
Feb 27, 2024
EmmadUsmani
added a commit
that referenced
this pull request
Feb 27, 2024
EmmadUsmani
added a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33342
Closes #32430
Description
For pie chart tooltips, we were incorrectly using the
.value
property of the pie chart slice. We can't use this because it is modified one case to make slices smaller than the minimum percentage setting look bigger.Instead, we should be using
slice.displayValue
, as was intendedDemo
Checklist