[QP] Fix confusion of expressions with the same name as columns #39255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bshepherdson and the rest of your teammates on |
bshepherdson
force-pushed
the
qp-handle-same-name-expressions
branch
from
d3d572e
to
1d62491
Compare
|
bshepherdson
force-pushed
the
qp-handle-same-name-expressions
branch
2 times, most recently
from
70c7c4d
to
30ccd18
Compare
bshepherdson
added
backport
bshepherdson
force-pushed
the
qp-handle-same-name-expressions
branch
from
30ccd18
to
3fe16d5
Compare
metamben
approved these changes
Mar 4, 2024
Comment on lines
+324
to
+327
| (defn- field-requires-original-field-name | ||
| "JSON extraction fields need to be named with their outer `field-name`, not use any existing `::desired-alias`." | ||
| [field-clause] | ||
| (boolean (some-> field-clause field-instance :nfc-path))) |
There was a problem hiding this comment.
Is there a test for this situation?
There was a problem hiding this comment.
Yes, but unfortunately they're DB-specific because JSON unfolding support is not widespread.
bshepherdson
added a commit
that referenced
this pull request
Mar 4, 2024
bshepherdson
added a commit
that referenced
this pull request
Mar 4, 2024
bshepherdson
added a commit
that referenced
this pull request
Mar 4, 2024
…olumns" Manual backport of #39255 to 48.
bshepherdson
added a commit
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When determining column aliases in
add-alias-info, reuse an existingdesired column alias if one is present.
Fixes #39059. Might fix #25931.