Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't delete "off" persisted_info records #39272

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Commits on Feb 28, 2024

  1. Don't delete "off" persisted_info records

    If they are off, they are "eligible" models for persistence that we do
    not want to persist. And to remember that use choice to not persist them
    we need to keep the record around. This was handled previously, but
    #39219 was a bit too blunt. We
    had a bunch of records in a "creating" state that we weren't removing,
    so i deleted them regardless of state. But we want to make sure that the
    "off" ones are not deleted.
    
    On stats, a bunch of ones that were set to off are now slated to be
    persisted after the prune job deleted the persisted_info records.
    dpsutton committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c1a9148 View commit details
    Browse the repository at this point in the history
  2. unused local. whoops

    dpsutton committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    ea743e2 View commit details
    Browse the repository at this point in the history