New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch back to ring-jetty-adapter - addresses security issue #39321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piranha
added
the
backport
Automatically create PR on current release branch on merge
label
Feb 29, 2024
|
escherize
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@piranha Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
@metabase-bot backport release-x.49.x |
darksciencebase
pushed a commit
that referenced
this pull request
Feb 29, 2024
piranha
added a commit
that referenced
this pull request
Mar 18, 2024
WiNloSt
pushed a commit
that referenced
this pull request
Mar 19, 2024
WiNloSt
added a commit
that referenced
this pull request
Mar 19, 2024
* update graalvm (#38218) * update deps with security issues (#39286) * switch back to ring-jetty-adapter - addresses security issue (#39321) * Bump clojure to 11.1.2 (#39857) * Bump dependencies based on vulnerabilities (#36504) * Bump dependencies based on vulnerabilities * More deps bumped * Bump more deps * Rollback H2 dependency bump * Add comments and make guava match elsewhere. --------- Co-authored-by: Alexander Solovyov <alexander@solovyov.net> Co-authored-by: Noah Moss <32746338+noahmoss@users.noreply.github.com> Co-authored-by: Case Nelson <case@metabase.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Automatically create PR on current release branch on merge
.Team/BackendComponents
also known as BEC
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since jetty is still a security issue, and ring-jetty9-adapter actually pulls http2-server - which we don't use and don't need in our deps.