🤖 backported "[FIX: #39152] Public links refer to null when question is new"
#39488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![metabase-bot[bot]](https://avatars.githubusercontent.com/in/220029?s=60&v=4){kind=small}
metabase-bot
bot
added
the
was-backported
oisincoveney
force-pushed
the
backport-ead86bf61082c6690d04e4f4a829e25fb0c88c25
branch
from
db9a449
to
1a82745
Compare
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 4479481...c9334a9. No notifications. |
|
WiNloSt
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
This looks exactly like https://github.com/metabase/metabase/pull/39154/files with one manual conflict fix.
| } | ||
| /> | ||
| ), | ||
| !question.isDataset() && |
There was a problem hiding this comment.
I believe this is the only single place that conflicts with #39047 in master. The conflict resolution looks fine to me.
oisincoveney
deleted the
backport-ead86bf61082c6690d04e4f4a829e25fb0c88c25
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #39154